Skip to content

Commit 99fc853

Browse files
authored
Rename line -> lines and sample -> samples since these are repeated fields (#712)
1 parent a59a58f commit 99fc853

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

CHANGELOG.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,12 @@
11
# Changelog
22

3+
The full list of changes can be found in the compare view for the respective release at <https://github.com/open-telemetry/opentelemetry-proto/releases>.
4+
35
## Unreleased
46

5-
The full list of changes can be found in the compare view for the respective release at <https://github.com/open-telemetry/opentelemetry-proto/releases>.
7+
### Changed
8+
9+
- profiles: rename line -> lines and sample -> samples since they are repeated fields. [#712](https://github.com/open-telemetry/opentelemetry-proto/pull/712)
610

711
### Removed
812

opentelemetry/proto/profiles/v1development/profiles.proto

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ message Profile {
248248
// ["allocated_objects","count"] or ["allocated_space","bytes"],
249249
ValueType sample_type = 1;
250250
// The set of samples recorded in this profile.
251-
repeated Sample sample = 2;
251+
repeated Sample samples = 2;
252252

253253
// The following fields 3-12 are informational, do not affect
254254
// interpretation of results.
@@ -394,9 +394,9 @@ message Location {
394394
// preceding entries were inlined.
395395
//
396396
// E.g., if memcpy() is inlined into printf:
397-
// line[0].function_name == "memcpy"
398-
// line[1].function_name == "printf"
399-
repeated Line line = 3;
397+
// lines[0].function_name == "memcpy"
398+
// lines[1].function_name == "printf"
399+
repeated Line lines = 3;
400400
// References to attributes in ProfilesDictionary.attribute_table. [optional]
401401
repeated int32 attribute_indices = 4;
402402
}

0 commit comments

Comments
 (0)