Skip to content

Commit 06ab153

Browse files
committed
Simplify invocation of pylint.
1 parent 6b66fe4 commit 06ab153

File tree

2 files changed

+45
-2
lines changed
  • instrumentation-genai/opentelemetry-instrumentation-google-genai

2 files changed

+45
-2
lines changed

instrumentation-genai/opentelemetry-instrumentation-google-genai/Makefile

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
.PHONY: all test install clean
15+
.PHONY: all test install clean lint
1616

17-
all: build test
17+
all: build test lint
1818

1919
test:
2020
./tools/test.sh
@@ -27,6 +27,10 @@ build: ./dist/opentelemetry_instrumentation_google_genai-0.0.1-py3-none-any.whl
2727
install: ./dist/opentelemetry_instrumentation_google_genai-0.0.1-py3-none-any.whl
2828
pip install ./dist/opentelemetry_instrumentation_google_genai-0.0.1-py3-none-any.whl
2929

30+
31+
lint:
32+
./tools/lint.sh
33+
3034
clean:
3135
rm -rf .test
3236
rm -rf .build
Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,39 @@
1+
#!/bin/bash
2+
3+
# Copyright The OpenTelemetry Authors
4+
#
5+
# Licensed under the Apache License, Version 2.0 (the "License");
6+
# you may not use this file except in compliance with the License.
7+
# You may obtain a copy of the License at
8+
#
9+
# http://www.apache.org/licenses/LICENSE-2.0
10+
#
11+
# Unless required by applicable law or agreed to in writing, software
12+
# distributed under the License is distributed on an "AS IS" BASIS,
13+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14+
# See the License for the specific language governing permissions and
15+
# limitations under the License.
16+
17+
SCRIPT_DIR=$(cd $(dirname "${BASH_SOURCE:-$0}"); pwd)
18+
PROJECT_DIR=$(readlink -f "${SCRIPT_DIR}/..")
19+
BUILD_DIR="${PROJECT_DIR}/.build"
20+
LINT_ENV="${BUILD_DIR}/.lint-venv"
21+
22+
function main() {
23+
if [ ! -d "${LINT_ENV}" ] ; then
24+
mkdir -p "${LINT_ENV}" || exit 1
25+
fi
26+
if [ ! -e "${LINT_ENV}/bin/activate" ] ; then
27+
python3 -m venv "${LINT_ENV}" || exit 1
28+
fi
29+
source "${LINT_ENV}/bin/activate" || exit 1
30+
pip install pylint || exit 1
31+
cd "${PROJECT_DIR}" || exit 1
32+
local current_dir=$(pwd)
33+
echo "[INFO] Current directory: ${current_dir}" >&2
34+
echo "[INFO] Executing:" >&2
35+
echo " pylint --rcfile=../../.pylintrc --ignore=.build,.test,.venv,.env,.tox" >&2
36+
pylint --rcfile=../../.pylintrc --ignore=.build,.test,.venv,.env,.tox . || exit $?
37+
}
38+
39+
main

0 commit comments

Comments
 (0)