End span only if it's still recording in stream done callbacks. Assert that span status is unset.

Author: SrdjanLL

instrumentation/opentelemetry-instrumentation-botocore/src/opentelemetry/instrumentation/botocore/extensions/bedrock.py

@@ -644,7 +644,8 @@ def stream_done_callback(response):
                     self._converse_on_success(
                         span, response, instrumentor_context, capture_content
                     )
-                    span.end()
+                    if span.is_recording():
+                        span.end()
 
                 def stream_error_callback(exception):
                     self._on_stream_error_callback(
@@ -684,7 +685,8 @@ def invoke_model_stream_done_callback(response):
                     self._converse_on_success(
                         span, response, instrumentor_context, capture_content
                     )
-                    span.end()
+                    if span.is_recording():
+                        span.end()
 
                 def invoke_model_stream_error_callback(exception):
                     self._on_stream_error_callback(

instrumentation/opentelemetry-instrumentation-botocore/tests/test_botocore_bedrock.py

@@ -1157,9 +1157,7 @@ def test_converse_stream_close_before_consumption(
         request_max_tokens=max_tokens,
         request_stop_sequences=stop_sequences,
     )
-    # No error status check - span should be closed normally
-    assert span.status.status_code != StatusCode.ERROR
-
+    assert span.status.status_code == StatusCode.UNSET
     logs = log_exporter.get_finished_logs()
 
     assert len(logs) == 1
@@ -2709,8 +2707,7 @@ def test_invoke_model_with_response_stream_close_before_consumption(
         if model_family == "meta.llama"
         else stop_sequences,
     )
-    # No error status check - span should be closed normally
-    assert span.status.status_code != StatusCode.ERROR
+    assert span.status.status_code == StatusCode.UNSET
 
     logs = log_exporter.get_finished_logs()
     assert len(logs) == 1