Skip to content

Commit 0abbaee

Browse files
committed
fix typing and lint
1 parent 0ee8358 commit 0abbaee

File tree

2 files changed

+29
-29
lines changed
  • instrumentation/opentelemetry-instrumentation-redis/src/opentelemetry/instrumentation/redis

2 files changed

+29
-29
lines changed
Lines changed: 22 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
from __future__ import annotations
22

3-
from typing import TYPE_CHECKING, Any, Callable, TypeVar
3+
from typing import Any, Callable, TypeVar
44

55
import redis.asyncio.client
66
import redis.asyncio.cluster
@@ -10,26 +10,25 @@
1010

1111
from opentelemetry.trace import Span
1212

13-
if TYPE_CHECKING:
14-
RequestHook = Callable[
15-
[Span, redis.connection.Connection, list[Any], dict[str, Any]], None
16-
]
17-
ResponseHook = Callable[[Span, redis.connection.Connection, Any], None]
13+
RequestHook = Callable[
14+
[Span, redis.connection.Connection, list[Any], dict[str, Any]], None
15+
]
16+
ResponseHook = Callable[[Span, redis.connection.Connection, Any], None]
1817

19-
AsyncPipelineInstance = TypeVar(
20-
"AsyncPipelineInstance",
21-
redis.asyncio.client.Pipeline,
22-
redis.asyncio.cluster.ClusterPipeline,
23-
)
24-
AsyncRedisInstance = TypeVar(
25-
"AsyncRedisInstance", redis.asyncio.Redis, redis.asyncio.RedisCluster
26-
)
27-
PipelineInstance = TypeVar(
28-
"PipelineInstance",
29-
redis.client.Pipeline,
30-
redis.cluster.ClusterPipeline,
31-
)
32-
RedisInstance = TypeVar(
33-
"RedisInstance", redis.client.Redis, redis.cluster.RedisCluster
34-
)
35-
R = TypeVar("R")
18+
AsyncPipelineInstance = TypeVar(
19+
"AsyncPipelineInstance",
20+
redis.asyncio.client.Pipeline,
21+
redis.asyncio.cluster.ClusterPipeline,
22+
)
23+
AsyncRedisInstance = TypeVar(
24+
"AsyncRedisInstance", redis.asyncio.Redis, redis.asyncio.RedisCluster
25+
)
26+
PipelineInstance = TypeVar(
27+
"PipelineInstance",
28+
redis.client.Pipeline,
29+
redis.cluster.ClusterPipeline,
30+
)
31+
RedisInstance = TypeVar(
32+
"RedisInstance", redis.client.Redis, redis.cluster.RedisCluster
33+
)
34+
R = TypeVar("R")

instrumentation/opentelemetry-instrumentation-redis/src/opentelemetry/instrumentation/redis/util.py

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,19 +20,20 @@
2020

2121
from typing import TYPE_CHECKING, Any
2222

23+
from opentelemetry.semconv.trace import (
24+
DbSystemValues,
25+
NetTransportValues,
26+
SpanAttributes,
27+
)
28+
from opentelemetry.trace import Span
29+
2330
if TYPE_CHECKING:
2431
from opentelemetry.instrumentation.redis.custom_types import (
2532
AsyncPipelineInstance,
2633
AsyncRedisInstance,
2734
PipelineInstance,
2835
RedisInstance,
2936
)
30-
from opentelemetry.semconv.trace import (
31-
DbSystemValues,
32-
NetTransportValues,
33-
SpanAttributes,
34-
)
35-
from opentelemetry.trace import Span
3637

3738
_FIELD_TYPES = ["NUMERIC", "TEXT", "GEO", "TAG", "VECTOR"]
3839

0 commit comments

Comments
 (0)