Add histogram buckets test

Author: drewby

instrumentation-genai/opentelemetry-instrumentation-openai-v2/tests/conftest.py

@@ -17,10 +17,17 @@
     InMemoryLogExporter,
     SimpleLogRecordProcessor,
 )
-from opentelemetry.sdk.metrics import MeterProvider
+from opentelemetry.sdk.metrics import (
+    Histogram,
+    MeterProvider,
+)
 from opentelemetry.sdk.metrics.export import (
     InMemoryMetricReader,
 )
+from opentelemetry.sdk.metrics.view import (
+    ExplicitBucketHistogramAggregation,
+    View,
+)
 from opentelemetry.sdk.trace import TracerProvider
 from opentelemetry.sdk.trace.export import SimpleSpanProcessor
 from opentelemetry.sdk.trace.export.in_memory_span_exporter import (
@@ -64,7 +71,56 @@ def fixture_event_logger_provider(log_exporter):
 
 @pytest.fixture(scope="function", name="meter_provider")
 def fixture_meter_provider(metric_reader):
-    meter_provider = MeterProvider(metric_readers=[metric_reader])
+    TokenUsageHistogramView = View(
+        instrument_type=Histogram,
+        instrument_name="gen_ai.client.token.usage",
+        aggregation=ExplicitBucketHistogramAggregation(
+            boundaries=[
+                1,
+                4,
+                16,
+                64,
+                256,
+                1024,
+                4096,
+                16384,
+                65536,
+                262144,
+                1048576,
+                4194304,
+                16777216,
+                67108864,
+            ]
+        ),
+    )
+
+    DurationHistogramView = View(
+        instrument_type=Histogram,
+        instrument_name="gen_ai.client.operation.duration",
+        aggregation=ExplicitBucketHistogramAggregation(
+            boundaries=[
+                0.01,
+                0.02,
+                0.04,
+                0.08,
+                0.16,
+                0.32,
+                0.64,
+                1.28,
+                2.56,
+                5.12,
+                10.24,
+                20.48,
+                40.96,
+                81.92,
+            ]
+        ),
+    )
+
+    meter_provider = MeterProvider(
+        metric_readers=[metric_reader],
+        views=[TokenUsageHistogramView, DurationHistogramView],
+    )
 
     return meter_provider
 

instrumentation-genai/opentelemetry-instrumentation-openai-v2/tests/test_chat_completions.py

@@ -927,6 +927,8 @@ def test_chat_completion_metrics(
     )
     assert input_token_usage is not None
     assert input_token_usage.sum == 12
+    # assert against buckets [1, 4, 16, 64, 256, 1024, 4096, 16384, 65536, 262144, 1048576, 4194304, 16777216, 67108864]
+    assert input_token_usage.bucket_counts[2] == 1
     assert_all_metric_attributes(input_token_usage)
 
     output_token_usage = next(
@@ -940,4 +942,6 @@ def test_chat_completion_metrics(
     )
     assert output_token_usage is not None
     assert output_token_usage.sum == 5
+    # assert against buckets [1, 4, 16, 64, 256, 1024, 4096, 16384, 65536, 262144, 1048576, 4194304, 16777216, 67108864]
+    assert output_token_usage.bucket_counts[2] == 1
     assert_all_metric_attributes(output_token_usage)