Update json.dumps call to use different separators

Author: DylanRussell

instrumentation-genai/opentelemetry-instrumentation-vertexai/src/opentelemetry/instrumentation/vertexai/patch.py

@@ -224,7 +224,11 @@ def handle_response(
                     ):
                         span.set_attributes(
                             {
-                                k: json.dumps(v, cls=Base64JsonEncoder)
+                                k: json.dumps(
+                                    v,
+                                    cls=Base64JsonEncoder,
+                                    separators=(",", ":"),
+                                )
                                 for k, v in content_attributes.items()
                             }
                         )

instrumentation-genai/opentelemetry-instrumentation-vertexai/tests/test_chat_completions_experimental.py

@@ -56,8 +56,8 @@ def test_generate_content(
         "gen_ai.usage.output_tokens": 5,
         "server.address": "us-central1-aiplatform.googleapis.com",
         "server.port": 443,
-        "gen_ai.input.messages": '[{"role": "user", "parts": [{"content": "Say this is a test", "type": "text"}]}]',
-        "gen_ai.output.messages": '[{"role": "model", "parts": [{"content": "This is a test.", "type": "text"}], "finish_reason": "stop"}]',
+        "gen_ai.input.messages": '[{"role":"user","parts":[{"content":"Say this is a test","type":"text"}]}]',
+        "gen_ai.output.messages": '[{"role":"model","parts":[{"content":"This is a test.","type":"text"}],"finish_reason":"stop"}]',
     }
 
     logs = log_exporter.get_finished_logs()
@@ -109,8 +109,8 @@ def test_generate_content_without_events(
     assert spans[0].name == "chat gemini-2.5-pro"
     assert dict(spans[0].attributes) == {
         "gen_ai.operation.name": "chat",
-        "gen_ai.output.messages": '[{"role": "model", "parts": [{"content": "This is a test.", "type": "text"}], "finish_reason": "stop"}]',
-        "gen_ai.input.messages": '[{"role": "user", "parts": [{"content": "Say this is a test", "type": "text"}]}]',
+        "gen_ai.output.messages": '[{"role":"model","parts":[{"content":"This is a test.","type":"text"}],"finish_reason":"stop"}]',
+        "gen_ai.input.messages": '[{"role":"user","parts":[{"content":"Say this is a test","type":"text"}]}]',
         "gen_ai.request.model": "gemini-2.5-pro",
         "gen_ai.response.finish_reasons": ("stop",),
         "gen_ai.response.model": "gemini-2.5-pro",
@@ -177,7 +177,7 @@ def test_generate_content_empty_model(
         "gen_ai.request.model": "",
         "server.address": "us-central1-aiplatform.googleapis.com",
         "server.port": 443,
-        "gen_ai.input.messages": '[{"role": "user", "parts": [{"content": "Say this is a test", "type": "text"}]}]',
+        "gen_ai.input.messages": '[{"role":"user","parts":[{"content":"Say this is a test","type":"text"}]}]',
     }
     assert_span_error(spans[0])
 
@@ -210,7 +210,7 @@ def test_generate_content_missing_model(
         "gen_ai.request.model": "gemini-does-not-exist",
         "server.address": "us-central1-aiplatform.googleapis.com",
         "server.port": 443,
-        "gen_ai.input.messages": '[{"role": "user", "parts": [{"content": "Say this is a test", "type": "text"}]}]',
+        "gen_ai.input.messages": '[{"role":"user","parts":[{"content":"Say this is a test","type":"text"}]}]',
     }
     assert_span_error(spans[0])
 
@@ -245,7 +245,7 @@ def test_generate_content_invalid_temperature(
         "gen_ai.request.temperature": 1000.0,
         "server.address": "us-central1-aiplatform.googleapis.com",
         "server.port": 443,
-        "gen_ai.input.messages": '[{"role": "user", "parts": [{"content": "Say this is a test", "type": "text"}]}]',
+        "gen_ai.input.messages": '[{"role":"user","parts":[{"content":"Say this is a test","type":"text"}]}]',
     }
     assert_span_error(spans[0])
 

instrumentation-genai/opentelemetry-instrumentation-vertexai/tests/test_function_calling_experimental.py

@@ -38,8 +38,8 @@ def test_function_call_choice(
         "gen_ai.usage.input_tokens": 74,
         "gen_ai.usage.output_tokens": 16,
         "server.address": "us-central1-aiplatform.googleapis.com",
-        "gen_ai.input.messages": '[{"role": "user", "parts": [{"content": "Get weather details in New Delhi and San Francisco?", "type": "text"}]}]',
-        "gen_ai.output.messages": '[{"role": "model", "parts": [{"arguments": {"location": "New Delhi"}, "name": "get_current_weather", "id": "get_current_weather_0", "type": "tool_call"}, {"arguments": {"location": "San Francisco"}, "name": "get_current_weather", "id": "get_current_weather_1", "type": "tool_call"}], "finish_reason": "stop"}]',
+        "gen_ai.input.messages": '[{"role":"user","parts":[{"content":"Get weather details in New Delhi and San Francisco?","type":"text"}]}]',
+        "gen_ai.output.messages": '[{"role":"model","parts":[{"arguments":{"location":"New Delhi"},"name":"get_current_weather","id":"get_current_weather_0","type":"tool_call"},{"arguments":{"location":"San Francisco"},"name":"get_current_weather","id":"get_current_weather_1","type":"tool_call"}],"finish_reason":"stop"}]',
         "server.port": 443,
     }
 
@@ -136,8 +136,8 @@ def test_tool_events(
         "gen_ai.usage.output_tokens": 26,
         "server.address": "us-central1-aiplatform.googleapis.com",
         "server.port": 443,
-        "gen_ai.input.messages": '[{"role": "user", "parts": [{"content": "Get weather details in New Delhi and San Francisco?", "type": "text"}]}, {"role": "model", "parts": [{"arguments": {"location": "New Delhi"}, "name": "get_current_weather", "id": "get_current_weather_0", "type": "tool_call"}, {"arguments": {"location": "San Francisco"}, "name": "get_current_weather", "id": "get_current_weather_1", "type": "tool_call"}]}, {"role": "user", "parts": [{"response": {"content": "{\\"temperature\\": 35, \\"unit\\": \\"C\\"}"}, "id": "get_current_weather_0", "type": "tool_call_response"}, {"response": {"content": "{\\"temperature\\": 25, \\"unit\\": \\"C\\"}"}, "id": "get_current_weather_1", "type": "tool_call_response"}]}]',
-        "gen_ai.output.messages": '[{"role": "model", "parts": [{"content": "The current temperature in New Delhi is 35\\u00b0C, and in San Francisco, it is 25\\u00b0C.", "type": "text"}], "finish_reason": "stop"}]',
+        "gen_ai.input.messages": '[{"role":"user","parts":[{"content":"Get weather details in New Delhi and San Francisco?","type":"text"}]},{"role":"model","parts":[{"arguments":{"location":"New Delhi"},"name":"get_current_weather","id":"get_current_weather_0","type":"tool_call"},{"arguments":{"location":"San Francisco"},"name":"get_current_weather","id":"get_current_weather_1","type":"tool_call"}]},{"role":"user","parts":[{"response":{"content":"{\\"temperature\\": 35, \\"unit\\": \\"C\\"}"},"id":"get_current_weather_0","type":"tool_call_response"},{"response":{"content":"{\\"temperature\\": 25, \\"unit\\": \\"C\\"}"},"id":"get_current_weather_1","type":"tool_call_response"}]}]',
+        "gen_ai.output.messages": '[{"role":"model","parts":[{"content":"The current temperature in New Delhi is 35\\u00b0C, and in San Francisco, it is 25\\u00b0C.","type":"text"}],"finish_reason":"stop"}]',
     }
     logs = log_exporter.get_finished_logs()
     assert len(logs) == 1