Skip to content

Commit 1d2e7c9

Browse files
Set db.statement after create sqlcomment
1 parent f6b68d0 commit 1d2e7c9

File tree

1 file changed

+5
-5
lines changed
  • instrumentation/opentelemetry-instrumentation-sqlalchemy/src/opentelemetry/instrumentation/sqlalchemy

1 file changed

+5
-5
lines changed

instrumentation/opentelemetry-instrumentation-sqlalchemy/src/opentelemetry/instrumentation/sqlalchemy/engine.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -218,11 +218,6 @@ def _before_cur_exec(
218218
kind=trace.SpanKind.CLIENT,
219219
)
220220
with trace.use_span(span, end_on_exit=False):
221-
if span.is_recording():
222-
span.set_attribute(SpanAttributes.DB_STATEMENT, statement)
223-
span.set_attribute(SpanAttributes.DB_SYSTEM, self.vendor)
224-
for key, value in attrs.items():
225-
span.set_attribute(key, value)
226221
if self.enable_commenter:
227222
commenter_data = {
228223
"db_driver": conn.engine.driver,
@@ -241,6 +236,11 @@ def _before_cur_exec(
241236
}
242237

243238
statement = _add_sql_comment(statement, **commenter_data)
239+
if span.is_recording():
240+
span.set_attribute(SpanAttributes.DB_STATEMENT, statement)
241+
span.set_attribute(SpanAttributes.DB_SYSTEM, self.vendor)
242+
for key, value in attrs.items():
243+
span.set_attribute(key, value)
244244

245245
context._otel_span = span
246246

0 commit comments

Comments
 (0)