Skip to content

Commit 27498de

Browse files
committed
Addressed feedback
1 parent 62f4ebd commit 27498de

File tree

1 file changed

+9
-18
lines changed
  • instrumentation/opentelemetry-instrumentation-django/src/opentelemetry/instrumentation/django/middleware

1 file changed

+9
-18
lines changed

instrumentation/opentelemetry-instrumentation-django/src/opentelemetry/instrumentation/django/middleware/otel_middleware.py

Lines changed: 9 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -167,24 +167,15 @@ class _DjangoMiddleware(MiddlewareMixin):
167167

168168
@staticmethod
169169
def format_request_objects_in_headers(attributes):
170-
for key, value_list in list(attributes.items()):
171-
new_values = []
172-
for value in value_list:
173-
if hasattr(value, "__class__"):
174-
if isinstance(value, HttpRequest):
175-
try:
176-
method = getattr(value, "method", "UNKNOWN")
177-
request_path = getattr(value, "path", "UNKNOWN")
178-
new_values.append(
179-
f"HttpRequest({method} {request_path})"
180-
)
181-
except (AttributeError, ValueError, TypeError):
182-
new_values.append("HttpRequest(...)")
183-
else:
184-
new_values.append(value)
185-
else:
186-
new_values.append(value)
187-
attributes[key] = new_values
170+
for key, value_list in attributes.items():
171+
for i, value in enumerate(value_list):
172+
if isinstance(value, HttpRequest):
173+
try:
174+
method = getattr(value, "method", "UNKNOWN")
175+
request_path = getattr(value, "path", "UNKNOWN")
176+
value_list[i] = f"HttpRequest({method} {request_path})"
177+
except Exception:
178+
value_list[i] = "HttpRequest(...)"
188179
return attributes
189180

190181
@staticmethod

0 commit comments

Comments
 (0)