Skip to content

Commit 341899d

Browse files
committed
bug_fix(1477): updated type handling for _add_sql_comment
1 parent cc7332d commit 341899d

File tree

3 files changed

+7
-3
lines changed
  • instrumentation
    • opentelemetry-instrumentation-dbapi/src/opentelemetry/instrumentation/dbapi
    • opentelemetry-instrumentation-django/src/opentelemetry/instrumentation/django/middleware
    • opentelemetry-instrumentation-sqlalchemy/src/opentelemetry/instrumentation/sqlalchemy

3 files changed

+7
-3
lines changed

instrumentation/opentelemetry-instrumentation-dbapi/src/opentelemetry/instrumentation/dbapi/__init__.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -491,6 +491,8 @@ def _update_args_with_added_sql_comment(self, args, cursor) -> tuple:
491491
# Convert sql statement to string, handling psycopg2.sql.Composable object
492492
if hasattr(args_list[0], "as_string"):
493493
args_list[0] = args_list[0].as_string(cursor.connection)
494+
495+
args_list[0] = str(args_list[0])
494496
statement = _add_sql_comment(args_list[0], **commenter_data)
495497
args_list[0] = statement
496498
args = tuple(args_list)

instrumentation/opentelemetry-instrumentation-django/src/opentelemetry/instrumentation/django/middleware/sqlcommenter_middleware.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,8 @@ def __call__(self, execute: Type[T], sql, params, many, context) -> T:
8484
if hasattr(sql, "as_string"):
8585
sql = sql.as_string(context["connection"])
8686

87+
sql = str(sql)
88+
8789
sql = _add_sql_comment(
8890
sql,
8991
# Information about the controller.

instrumentation/opentelemetry-instrumentation-sqlalchemy/src/opentelemetry/instrumentation/sqlalchemy/engine.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -274,9 +274,9 @@ def _before_cur_exec(
274274
commenter_data = self._get_commenter_data(conn)
275275

276276
if self.enable_attribute_commenter:
277-
# Convert sql statement to string, handling psycopg2.sql.Composable object
278-
if hasattr(statement, "as_string"):
279-
statement = statement.as_string(conn)
277+
# just to handle type safety
278+
statement = str(statement)
279+
280280
# sqlcomment is added to executed query and db.statement span attribute
281281
statement = _add_sql_comment(
282282
statement, **commenter_data

0 commit comments

Comments
 (0)