fix(fastapi-instrumentation): linter fix

Author: artemziborev

instrumentation/opentelemetry-instrumentation-fastapi/demo_memory_leak_fix.py

@@ -66,12 +66,14 @@ def demonstrate_multiple_cycles():
     print(f"Initial refcount: {initial_refcount}")
 
     # Perform multiple cycles
-    for i in range(3):
+    for cycle_num in range(3):
         FastAPIInstrumentor.instrument_app(app)
         FastAPIInstrumentor.uninstrument_app(app)
         current_refcount = sys.getrefcount(app)
         set_size = len(_InstrumentedFastAPI._instrumented_fastapi_apps)
-        print(f"Cycle {i+1}: refcount={current_refcount}, set_size={set_size}")
+        print(
+            f"Cycle {cycle_num+1}: refcount={current_refcount}, set_size={set_size}"
+        )
 
     final_refcount = sys.getrefcount(app)
     final_set_size = len(_InstrumentedFastAPI._instrumented_fastapi_apps)
@@ -92,18 +94,18 @@ def demonstrate_multiple_apps():
     apps = [fastapi.FastAPI() for _ in range(3)]
 
     print("Instrumenting all apps...")
-    for i, app in enumerate(apps):
+    for app_idx, app in enumerate(apps):
         FastAPIInstrumentor.instrument_app(app)
-        print(f"App {i}: refcount={sys.getrefcount(app)}")
+        print(f"App {app_idx}: refcount={sys.getrefcount(app)}")
 
     print(
         f"Set size after instrumenting: {len(_InstrumentedFastAPI._instrumented_fastapi_apps)}"
     )
 
     print("Uninstrumenting all apps...")
-    for i, app in enumerate(apps):
+    for app_idx, app in enumerate(apps):
         FastAPIInstrumentor.uninstrument_app(app)
-        print(f"App {i}: refcount={sys.getrefcount(app)}")
+        print(f"App {app_idx}: refcount={sys.getrefcount(app)}")
 
     final_set_size = len(_InstrumentedFastAPI._instrumented_fastapi_apps)
     print(f"Final set size: {final_set_size}")

instrumentation/opentelemetry-instrumentation-fastapi/tests/test_fastapi_memory_leak.py

@@ -17,7 +17,10 @@
 
 import fastapi
 
-from opentelemetry.instrumentation.fastapi import FastAPIInstrumentor
+from opentelemetry.instrumentation.fastapi import (
+    FastAPIInstrumentor,
+    _InstrumentedFastAPI,
+)
 
 
 class TestFastAPIMemoryLeak(unittest.TestCase):
@@ -43,8 +46,6 @@ def test_refcount_after_uninstrument(self):
         )
 
         # Verify that the app was removed from the set
-        from opentelemetry.instrumentation.fastapi import _InstrumentedFastAPI
-
         self.assertNotIn(
             app,
             _InstrumentedFastAPI._instrumented_fastapi_apps,
@@ -58,7 +59,7 @@ def test_multiple_instrument_uninstrument_cycles(self):
         initial_refcount = sys.getrefcount(app)
 
         # Perform multiple instrument/uninstrument cycles
-        for i in range(5):
+        for cycle_num in range(5):
             FastAPIInstrumentor.instrument_app(app)
             FastAPIInstrumentor.uninstrument_app(app)
 
@@ -70,12 +71,10 @@ def test_multiple_instrument_uninstrument_cycles(self):
             final_refcount,
             initial_refcount
             + 2,  # Allow small increase due to Python internals
-            f"Refcount after {i+1} instrument/uninstrument cycles should not grow significantly",
+            f"Refcount after {cycle_num+1} instrument/uninstrument cycles should not grow significantly",
         )
 
         # Verify that the app is not in the set
-        from opentelemetry.instrumentation.fastapi import _InstrumentedFastAPI
-
         self.assertNotIn(
             app,
             _InstrumentedFastAPI._instrumented_fastapi_apps,
@@ -96,18 +95,16 @@ def test_multiple_apps_instrument_uninstrument(self):
             FastAPIInstrumentor.uninstrument_app(app)
 
         # Check that refcounts are not significantly increased
-        for i, app in enumerate(apps):
+        for app_idx, app in enumerate(apps):
             final_refcount = sys.getrefcount(app)
             self.assertLessEqual(
                 final_refcount,
-                initial_refcounts[i]
+                initial_refcounts[app_idx]
                 + 2,  # Allow small increase due to Python internals
-                f"App {i} refcount should not grow significantly",
+                f"App {app_idx} refcount should not grow significantly",
             )
 
         # Verify that no apps are in the set
-        from opentelemetry.instrumentation.fastapi import _InstrumentedFastAPI
-
         for app in apps:
             self.assertNotIn(
                 app,
@@ -123,7 +120,6 @@ def test_demonstrate_fix(self):
         # After the fix: app should be removed from _instrumented_fastapi_apps
 
         FastAPIInstrumentor.instrument_app(app)
-        from opentelemetry.instrumentation.fastapi import _InstrumentedFastAPI
 
         # Verify app is in the set after instrumentation
         self.assertIn(app, _InstrumentedFastAPI._instrumented_fastapi_apps)