Skip to content

Commit 3929fa9

Browse files
committed
Add comment about custom attributes
1 parent 92ccc30 commit 3929fa9

File tree

2 files changed

+2
-1
lines changed
  • instrumentation-genai/opentelemetry-instrumentation-openai-v2/src/opentelemetry/instrumentation/openai_v2

2 files changed

+2
-1
lines changed

instrumentation-genai/opentelemetry-instrumentation-openai-v2/src/opentelemetry/instrumentation/openai_v2/patch.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ def traced_method(wrapped, instance, args, kwargs):
173173
)
174174
}
175175

176-
# Set embeddings dimensions if specified in the request
176+
# Using a custom attribute "gen_ai.embeddings.dimensions". Will propose to semantic conventions.
177177
if "dimensions" in kwargs and kwargs["dimensions"] is not None:
178178
span_attributes["gen_ai.embeddings.dimensions"] = kwargs[
179179
"dimensions"

instrumentation-genai/opentelemetry-instrumentation-openai-v2/src/opentelemetry/instrumentation/openai_v2/utils.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -245,6 +245,7 @@ def get_llm_request_attributes(
245245
attributes["gen_ai.embeddings.dimensions"] = kwargs["dimensions"]
246246

247247
# Add encoding format if specified
248+
# Using a custom attribute "gen_ai.embeddings.encoding_format". Will propose to semantic conventions.
248249
if "encoding_format" in kwargs:
249250
attributes["gen_ai.embeddings.encoding_format"] = kwargs[
250251
"encoding_format"

0 commit comments

Comments
 (0)