Skip to content

Commit 3d5ec55

Browse files
author
Filip Nikolovski
committed
fix tests
1 parent ecd351f commit 3d5ec55

File tree

1 file changed

+7
-3
lines changed
  • instrumentation/opentelemetry-instrumentation-falcon/tests

1 file changed

+7
-3
lines changed

instrumentation/opentelemetry-instrumentation-falcon/tests/test_falcon.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ def _test_method(self, method, old_semconv=True, new_semconv=False):
211211
SpanAttributes.HTTP_HOST: "falconframework.org",
212212
SpanAttributes.HTTP_TARGET: "/"
213213
if self._has_fixed_http_target
214-
else "/error",
214+
else "/hello",
215215
SpanAttributes.NET_PEER_PORT: 65133,
216216
SpanAttributes.HTTP_FLAVOR: "1.1",
217217
"falcon.resource": "HelloWorldResource",
@@ -223,7 +223,9 @@ def _test_method(self, method, old_semconv=True, new_semconv=False):
223223
SpanAttributes.SERVER_ADDRESS: "falconframework.org",
224224
SpanAttributes.URL_SCHEME: "http",
225225
SpanAttributes.SERVER_PORT: 80,
226-
SpanAttributes.URL_PATH: "/",
226+
SpanAttributes.URL_PATH: "/"
227+
if self._has_fixed_http_target
228+
else "/hello",
227229
SpanAttributes.CLIENT_PORT: 65133,
228230
SpanAttributes.NETWORK_PROTOCOL_VERSION: "1.1",
229231
"falcon.resource": "HelloWorldResource",
@@ -344,7 +346,9 @@ def test_url_template_new_semconv(self):
344346
SpanAttributes.SERVER_ADDRESS: "falconframework.org",
345347
SpanAttributes.URL_SCHEME: "http",
346348
SpanAttributes.SERVER_PORT: 80,
347-
SpanAttributes.URL_PATH: "/",
349+
SpanAttributes.URL_PATH: "/"
350+
if self._has_fixed_http_target
351+
else "/user/123",
348352
SpanAttributes.CLIENT_PORT: 65133,
349353
SpanAttributes.NETWORK_PROTOCOL_VERSION: "1.1",
350354
"falcon.resource": "UserResource",

0 commit comments

Comments
 (0)