test fastapi tests

Author: jeremydvoss

instrumentation/opentelemetry-instrumentation-fastapi/tests/test_fastapi_instrumentation.py

@@ -1095,50 +1095,89 @@ def test_instruments_with_fastapi_installed(self, mock_logger):
         mock_distro = Mock()
         mock_distro.load_instrumentor.return_value = None
         _load_instrumentors(mock_distro)
+        print(
+            "mock_distro.load_instrumentor.call_args_list: %s"
+            % mock_distro.load_instrumentor.call_args_list
+        )
         self.assertEqual(len(mock_distro.load_instrumentor.call_args_list), 1)
         (ep,) = mock_distro.load_instrumentor.call_args.args
         self.assertEqual(ep.name, "fastapi")
         mock_logger.debug.assert_has_calls(
             [self._instrumentation_loaded_successfully_call()]
         )
 
+    # TODO: fails
+    @patch(
+        "opentelemetry.instrumentation.auto_instrumentation._load.get_dist_dependency_conflicts"
+    )
     @patch("opentelemetry.instrumentation.auto_instrumentation._load._logger")
-    def test_instruments_with_old_fastapi_installed(self, mock_logger):  # pylint: disable=no-self-use
+    def test_instruments_with_old_fastapi_installed(
+        self, mock_logger, mock_dep
+    ):  # pylint: disable=no-self-use
         dependency_conflict = DependencyConflict("0.58", "0.57")
         mock_distro = Mock()
-        mock_distro.load_instrumentor.side_effect = DependencyConflictError(
-            dependency_conflict
-        )
+        # mock_distro.load_instrumentor.side_effect = DependencyConflictError(
+        #     dependency_conflict
+        # )
+        # TODO: return conflict instead of raising
+        mock_dep.return_value = DependencyConflictError(dependency_conflict)
         _load_instrumentors(mock_distro)
-        self.assertEqual(len(mock_distro.load_instrumentor.call_args_list), 1)
-        (ep,) = mock_distro.load_instrumentor.call_args.args
-        self.assertEqual(ep.name, "fastapi")
-        assert (
-            self._instrumentation_loaded_successfully_call()
-            not in mock_logger.debug.call_args_list
-        )
-        mock_logger.debug.assert_has_calls(
-            [self._instrumentation_failed_to_load_call(dependency_conflict)]
+        mock_distro.load_instrumentor.assert_not_called()
+        self.assertEqual(
+            mock_logger.debug.call_args.args,
+            (
+                "Skipping instrumentation %s: %s",
+                "fastapi",
+                dependency_conflict,
+            ),
         )
-
+        # print("mock_distro.load_instrumentor.call_args_list: %s" % mock_distro.load_instrumentor.call_args_list)
+        # self.assertEqual(len(mock_distro.load_instrumentor.call_args_list), 1)
+        # (ep,) = mock_distro.load_instrumentor.call_args.args
+        # self.assertEqual(ep.name, "fastapi")
+        # assert (
+        #     self._instrumentation_loaded_successfully_call()
+        #     not in mock_logger.debug.call_args_list
+        # )
+        # mock_logger.debug.assert_has_calls(
+        #     [self._instrumentation_failed_to_load_call(dependency_conflict)]
+        # )
+
+    # TODO: fails
+    @patch(
+        "opentelemetry.instrumentation.auto_instrumentation._load.get_dist_dependency_conflicts"
+    )
     @patch("opentelemetry.instrumentation.auto_instrumentation._load._logger")
-    def test_instruments_without_fastapi_installed(self, mock_logger):  # pylint: disable=no-self-use
+    def test_instruments_without_fastapi_installed(
+        self, mock_logger, mock_dep
+    ):  # pylint: disable=no-self-use
         dependency_conflict = DependencyConflict("0.58", None)
         mock_distro = Mock()
-        mock_distro.load_instrumentor.side_effect = DependencyConflictError(
-            dependency_conflict
-        )
+        # mock_distro.load_instrumentor.side_effect = DependencyConflictError(
+        #     dependency_conflict
+        # )
+        mock_dep.return_value = DependencyConflictError(dependency_conflict)
         _load_instrumentors(mock_distro)
-        self.assertEqual(len(mock_distro.load_instrumentor.call_args_list), 1)
-        (ep,) = mock_distro.load_instrumentor.call_args.args
-        self.assertEqual(ep.name, "fastapi")
-        assert (
-            self._instrumentation_loaded_successfully_call()
-            not in mock_logger.debug.call_args_list
-        )
-        mock_logger.debug.assert_has_calls(
-            [self._instrumentation_failed_to_load_call(dependency_conflict)]
+        mock_distro.load_instrumentor.assert_not_called()
+        self.assertEqual(
+            mock_logger.debug.call_args.args,
+            (
+                "Skipping instrumentation %s: %s",
+                "fastapi",
+                dependency_conflict,
+            ),
         )
+        # print("mock_distro.load_instrumentor.call_args_list: %s" % mock_distro.load_instrumentor.call_args_list)
+        # self.assertEqual(len(mock_distro.load_instrumentor.call_args_list), 1)
+        # (ep,) = mock_distro.load_instrumentor.call_args.args
+        # self.assertEqual(ep.name, "fastapi")
+        # assert (
+        #     self._instrumentation_loaded_successfully_call()
+        #     not in mock_logger.debug.call_args_list
+        # )
+        # mock_logger.debug.assert_has_calls(
+        #     [self._instrumentation_failed_to_load_call(dependency_conflict)]
+        # )
 
     def _create_app(self):
         # instrumentation is handled by the instrument call