record FastAPI hook exceptions in active span

Author: outergod

instrumentation/opentelemetry-instrumentation-fastapi/src/opentelemetry/instrumentation/fastapi/__init__.py

@@ -209,7 +209,7 @@ def client_response_hook(span: Span, scope: dict[str, Any], message: dict[str, A
 from opentelemetry.instrumentation.instrumentor import BaseInstrumentor
 from opentelemetry.metrics import MeterProvider, get_meter
 from opentelemetry.semconv.attributes.http_attributes import HTTP_ROUTE
-from opentelemetry.trace import TracerProvider, get_tracer
+from opentelemetry.trace import Span, TracerProvider, get_tracer
 from opentelemetry.util.http import (
     get_excluded_urls,
     parse_excluded_urls,
@@ -296,11 +296,18 @@ def instrument_app(
             def build_middleware_stack(self: Starlette) -> ASGIApp:
                 def failsafe(func):
                     @functools.wraps(func)
-                    def wrapper(*args, **kwargs):
+                    def wrapper(span: Span, *args, **kwargs):
                         try:
-                            func(*args, **kwargs)
-                        except Exception:  # pylint: disable=W0718
-                            pass
+                            func(span, *args, **kwargs)
+                        except Exception as exc:  # pylint: disable=W0718
+                            span.record_exception(exc)
+                            # span.set_status(Status(StatusCode.ERROR, str(exc)))
+                            # if span.is_recording():
+                            #     span.set_attribute(
+                            #         ErrorAttributes.ERROR_TYPE, type(exc).__qualname__
+                            #     )
+                            # if span.record_exception
+                            # span.end()
 
                     return wrapper
 

instrumentation/opentelemetry-instrumentation-fastapi/tests/test_fastapi_instrumentation.py

@@ -59,6 +59,9 @@
 from opentelemetry.semconv._incubating.attributes.net_attributes import (
     NET_HOST_PORT,
 )
+from opentelemetry.semconv.attributes.exception_attributes import (
+    EXCEPTION_TYPE,
+)
 from opentelemetry.semconv.attributes.http_attributes import (
     HTTP_REQUEST_METHOD,
     HTTP_RESPONSE_STATUS_CODE,
@@ -1981,3 +1984,22 @@ def test_failsafe_hooks(self):
         )
 
         self.assertEqual(200, resp.status_code)
+
+    def test_failsafe_error_recording(self):
+        """Failing hooks must record the exception on the span"""
+        self.client.get(
+            "/foobar",
+        )
+
+        spans = self.memory_exporter.get_finished_spans()
+
+        self.assertEqual(len(spans), 3)
+        span = spans[0]
+        self.assertEqual(len(span.events), 1)
+        event = span.events[0]
+        self.assertEqual(event.name, "exception")
+        assert event.attributes is not None
+        self.assertEqual(
+            event.attributes.get(EXCEPTION_TYPE),
+            f"{__name__}.UnhandledException",
+        )