Skip to content

Commit 58daeb6

Browse files
Update typehints
1 parent e148c9f commit 58daeb6

File tree

2 files changed

+10
-4
lines changed
  • instrumentation
    • opentelemetry-instrumentation-psycopg2/src/opentelemetry/instrumentation/psycopg2
    • opentelemetry-instrumentation-psycopg/src/opentelemetry/instrumentation/psycopg

2 files changed

+10
-4
lines changed

instrumentation/opentelemetry-instrumentation-psycopg/src/opentelemetry/instrumentation/psycopg/__init__.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,9 @@
109109
from psycopg import (
110110
AsyncCursor as pg_async_cursor, # pylint: disable=import-self,no-name-in-module
111111
)
112+
from psycopg import (
113+
Connection as pg_connection, # pylint: disable=no-name-in-module
114+
)
112115
from psycopg import (
113116
Cursor as pg_cursor, # pylint: disable=no-name-in-module,import-self
114117
)
@@ -197,8 +200,8 @@ def _uninstrument(self, **kwargs):
197200
# TODO(owais): check if core dbapi can do this for all dbapi implementations e.g, pymysql and mysql
198201
@staticmethod
199202
def instrument_connection(
200-
connection,
201-
tracer_provider=None,
203+
connection: pg_connection,
204+
tracer_provider: typing.Optional[trace_api.TracerProvider] = None,
202205
enable_commenter: bool = False,
203206
commenter_options: dict = None,
204207
):

instrumentation/opentelemetry-instrumentation-psycopg2/src/opentelemetry/instrumentation/psycopg2/__init__.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,9 @@
106106
from typing import Collection
107107

108108
import psycopg2
109+
from psycopg2.extensions import (
110+
connection as pg_connection, # pylint: disable=no-name-in-module
111+
)
109112
from psycopg2.extensions import (
110113
cursor as pg_cursor, # pylint: disable=no-name-in-module
111114
)
@@ -161,8 +164,8 @@ def _uninstrument(self, **kwargs):
161164
# TODO(owais): check if core dbapi can do this for all dbapi implementations e.g, pymysql and mysql
162165
@staticmethod
163166
def instrument_connection(
164-
connection,
165-
tracer_provider=None,
167+
connection: pg_connection,
168+
tracer_provider: typing.Optional[trace_api.TracerProvider] = None,
166169
enable_commenter: bool = False,
167170
commenter_options: dict = None,
168171
):

0 commit comments

Comments
 (0)