fix: remove json.dumps from SERVER_ADDRESS attribute

Author: dimastbk

instrumentation/opentelemetry-instrumentation-aiokafka/src/opentelemetry/instrumentation/aiokafka/utils.py

@@ -1,7 +1,6 @@
 from __future__ import annotations
 
 import asyncio
-import json
 from logging import getLogger
 from typing import (
     TYPE_CHECKING,
@@ -213,9 +212,7 @@ def _enrich_base_span(
         messaging_attributes.MESSAGING_SYSTEM,
         messaging_attributes.MessagingSystemValues.KAFKA.value,
     )
-    span.set_attribute(
-        server_attributes.SERVER_ADDRESS, json.dumps(bootstrap_servers)
-    )
+    span.set_attribute(server_attributes.SERVER_ADDRESS, bootstrap_servers)
     span.set_attribute(messaging_attributes.MESSAGING_CLIENT_ID, client_id)
     span.set_attribute(messaging_attributes.MESSAGING_DESTINATION_NAME, topic)
 
@@ -324,9 +321,7 @@ def _enrich_getmany_poll_span(
         messaging_attributes.MESSAGING_SYSTEM,
         messaging_attributes.MessagingSystemValues.KAFKA.value,
     )
-    span.set_attribute(
-        server_attributes.SERVER_ADDRESS, json.dumps(bootstrap_servers)
-    )
+    span.set_attribute(server_attributes.SERVER_ADDRESS, bootstrap_servers)
     span.set_attribute(messaging_attributes.MESSAGING_CLIENT_ID, client_id)
 
     if consumer_group is not None:

instrumentation/opentelemetry-instrumentation-aiokafka/tests/test_instrumentation.py

@@ -161,7 +161,7 @@ async def test_getone(self) -> None:
                 "kind": SpanKind.CONSUMER,
                 "attributes": {
                     messaging_attributes.MESSAGING_SYSTEM: messaging_attributes.MessagingSystemValues.KAFKA.value,
-                    server_attributes.SERVER_ADDRESS: '"localhost"',
+                    server_attributes.SERVER_ADDRESS: "localhost",
                     messaging_attributes.MESSAGING_CLIENT_ID: client_id,
                     messaging_attributes.MESSAGING_DESTINATION_NAME: "topic_1",
                     messaging_attributes.MESSAGING_DESTINATION_PARTITION_ID: "1",
@@ -178,7 +178,7 @@ async def test_getone(self) -> None:
                 "kind": SpanKind.CONSUMER,
                 "attributes": {
                     messaging_attributes.MESSAGING_SYSTEM: messaging_attributes.MessagingSystemValues.KAFKA.value,
-                    server_attributes.SERVER_ADDRESS: '"localhost"',
+                    server_attributes.SERVER_ADDRESS: "localhost",
                     messaging_attributes.MESSAGING_CLIENT_ID: client_id,
                     messaging_attributes.MESSAGING_DESTINATION_NAME: "topic_2",
                     messaging_attributes.MESSAGING_DESTINATION_PARTITION_ID: "2",
@@ -296,7 +296,7 @@ async def test_getmany(self) -> None:
                 "kind": SpanKind.CONSUMER,
                 "attributes": {
                     messaging_attributes.MESSAGING_SYSTEM: messaging_attributes.MessagingSystemValues.KAFKA.value,
-                    server_attributes.SERVER_ADDRESS: '"localhost"',
+                    server_attributes.SERVER_ADDRESS: "localhost",
                     messaging_attributes.MESSAGING_CLIENT_ID: client_id,
                     messaging_attributes.MESSAGING_DESTINATION_NAME: "topic_1",
                     messaging_attributes.MESSAGING_DESTINATION_PARTITION_ID: "1",
@@ -313,7 +313,7 @@ async def test_getmany(self) -> None:
                 "kind": SpanKind.CLIENT,
                 "attributes": {
                     messaging_attributes.MESSAGING_SYSTEM: messaging_attributes.MessagingSystemValues.KAFKA.value,
-                    server_attributes.SERVER_ADDRESS: '"localhost"',
+                    server_attributes.SERVER_ADDRESS: "localhost",
                     messaging_attributes.MESSAGING_CLIENT_ID: client_id,
                     messaging_attributes.MESSAGING_DESTINATION_NAME: "topic_1",
                     messaging_attributes.MESSAGING_DESTINATION_PARTITION_ID: "1",
@@ -328,7 +328,7 @@ async def test_getmany(self) -> None:
                 "kind": SpanKind.CONSUMER,
                 "attributes": {
                     messaging_attributes.MESSAGING_SYSTEM: messaging_attributes.MessagingSystemValues.KAFKA.value,
-                    server_attributes.SERVER_ADDRESS: '"localhost"',
+                    server_attributes.SERVER_ADDRESS: "localhost",
                     messaging_attributes.MESSAGING_CLIENT_ID: client_id,
                     messaging_attributes.MESSAGING_DESTINATION_NAME: "topic_2",
                     messaging_attributes.MESSAGING_DESTINATION_PARTITION_ID: "2",
@@ -345,7 +345,7 @@ async def test_getmany(self) -> None:
                 "kind": SpanKind.CLIENT,
                 "attributes": {
                     messaging_attributes.MESSAGING_SYSTEM: messaging_attributes.MessagingSystemValues.KAFKA.value,
-                    server_attributes.SERVER_ADDRESS: '"localhost"',
+                    server_attributes.SERVER_ADDRESS: "localhost",
                     messaging_attributes.MESSAGING_CLIENT_ID: client_id,
                     messaging_attributes.MESSAGING_DESTINATION_NAME: "topic_2",
                     messaging_attributes.MESSAGING_DESTINATION_PARTITION_ID: "2",
@@ -360,7 +360,7 @@ async def test_getmany(self) -> None:
                 "kind": SpanKind.CLIENT,
                 "attributes": {
                     messaging_attributes.MESSAGING_SYSTEM: messaging_attributes.MessagingSystemValues.KAFKA.value,
-                    server_attributes.SERVER_ADDRESS: '"localhost"',
+                    server_attributes.SERVER_ADDRESS: "localhost",
                     messaging_attributes.MESSAGING_CLIENT_ID: client_id,
                     messaging_attributes.MESSAGING_CONSUMER_GROUP_NAME: group_id,
                     messaging_attributes.MESSAGING_OPERATION_NAME: "poll",