fix: clean up nits

Author: keith-decker

util/opentelemetry-util-genai/src/opentelemetry/util/genai/span_utils.py

@@ -137,8 +137,8 @@ def _apply_response_attributes(span: Span, invocation: LLMInvocation) -> None:
     attributes: Dict[str, Any] = {}
 
     finish_reasons: Optional[List[str]]
-    if invocation.response_finish_reasons is not None:
-        finish_reasons = invocation.response_finish_reasons
+    if invocation.finish_reasons is not None:
+        finish_reasons = invocation.finish_reasons
     elif invocation.output_messages:
         finish_reasons = [
             message.finish_reason for message in invocation.output_messages

util/opentelemetry-util-genai/src/opentelemetry/util/genai/types.py

@@ -111,7 +111,7 @@ class LLMInvocation:
     provider: Optional[str] = None
     response_model_name: Optional[str] = None
     response_id: Optional[str] = None
-    response_finish_reasons: Optional[List[str]] = None
+    finish_reasons: Optional[List[str]] = None
     input_tokens: Optional[int] = None
     output_tokens: Optional[int] = None
     attributes: Dict[str, Any] = field(default_factory=_new_str_any_dict)

util/opentelemetry-util-genai/tests/test_utils.py

@@ -34,6 +34,7 @@
 from opentelemetry.semconv.attributes import (
     error_attributes as ErrorAttributes,
 )
+from opentelemetry.semconv.schemas import Schemas
 from opentelemetry.trace.status import StatusCode
 from opentelemetry.util.genai.environment_variables import (
     OTEL_INSTRUMENTATION_GENAI_CAPTURE_MESSAGE_CONTENT,
@@ -209,7 +210,7 @@ def test_llm_start_and_stop_creates_span(self):  # pylint: disable=no-self-use
                 "temperature": 0.5,
                 "top_p": 0.9,
                 "stop_sequences": ["stop"],
-                "response_finish_reasons": ["stop"],
+                "finish_reasons": ["stop"],
                 "response_model_name": "test-response-model",
                 "response_id": "response-id",
                 "input_tokens": 321,
@@ -229,8 +230,8 @@ def test_llm_start_and_stop_creates_span(self):  # pylint: disable=no-self-use
         _assert_span_attributes(
             span_attrs,
             {
-                "gen_ai.operation.name": "chat",
-                "gen_ai.provider.name": "test-provider",
+                GenAI.GEN_AI_OPERATION_NAME: "chat",
+                GenAI.GEN_AI_PROVIDER_NAME: "test-provider",
                 GenAI.GEN_AI_REQUEST_TEMPERATURE: 0.5,
                 GenAI.GEN_AI_REQUEST_TOP_P: 0.9,
                 GenAI.GEN_AI_REQUEST_STOP_SEQUENCES: ("stop",),
@@ -294,7 +295,7 @@ def test_llm_span_finish_reasons_without_output_messages(self):
         invocation = LLMInvocation(
             request_model="model-without-output",
             provider="test-provider",
-            response_finish_reasons=["length"],
+            finish_reasons=["length"],
             response_model_name="alt-model",
             response_id="resp-001",
             input_tokens=12,
@@ -319,6 +320,27 @@ def test_llm_span_finish_reasons_without_output_messages(self):
             },
         )
 
+    def test_llm_span_uses_expected_schema_url(self):
+        invocation = LLMInvocation(
+            request_model="schema-model",
+            provider="schema-provider",
+        )
+
+        self.telemetry_handler.start_llm(invocation)
+        assert invocation.span is not None
+        self.telemetry_handler.stop_llm(invocation)
+
+        span = _get_single_span(self.span_exporter)
+        instrumentation = getattr(span, "instrumentation_scope", None)
+        if instrumentation is None:
+            instrumentation = getattr(span, "instrumentation_info", None)
+
+        assert instrumentation is not None
+        assert (
+            getattr(instrumentation, "schema_url", None)
+            == Schemas.V1_37_0.value
+        )
+
     @patch_env_vars(
         stability_mode="gen_ai_latest_experimental",
         content_capturing="SPAN_ONLY",
@@ -379,7 +401,7 @@ class BoomError(RuntimeError):
                 for attr, value in {
                     "max_tokens": 128,
                     "seed": 123,
-                    "response_finish_reasons": ["error"],
+                    "finish_reasons": ["error"],
                     "response_model_name": "error-model",
                     "response_id": "error-response",
                     "input_tokens": 11,