Skip to content

Commit 659007c

Browse files
committed
Add db for both name and database_index
1 parent 8541371 commit 659007c

File tree

2 files changed

+2
-5
lines changed
  • instrumentation/opentelemetry-instrumentation-redis/src/opentelemetry/instrumentation/redis
  • tests/opentelemetry-docker-tests/tests/redis

2 files changed

+2
-5
lines changed

instrumentation/opentelemetry-instrumentation-redis/src/opentelemetry/instrumentation/redis/util.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,8 @@ def _extract_conn_attributes(conn_kwargs):
2323
"db.system": "redis",
2424
}
2525
db = conn_kwargs.get("db", 0)
26-
if db == 0:
27-
attributes["db.name"] = db
28-
else:
29-
attributes["db.redis.database_index"] = db
26+
attributes["db.name"] = db
27+
attributes["db.redis.database_index"] = db
3028
try:
3129
attributes["net.peer.name"] = conn_kwargs["host"]
3230
attributes["net.peer.ip"] = conn_kwargs["port"]

tests/opentelemetry-docker-tests/tests/redis/test_redis_functional.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,6 @@ def _check_span(self, span, name):
134134
self.assertEqual(span.attributes["net.peer.name"], "localhost")
135135
self.assertEqual(span.attributes["net.peer.ip"], 6379)
136136
self.assertEqual(span.attributes["db.redis.database_index"], 10)
137-
self.assertNotIn("db.name", span.attributes)
138137

139138
def test_get(self):
140139
self.assertIsNone(self.redis_client.get("foo"))

0 commit comments

Comments
 (0)