removed start time from span state and moved error handler method to span manager

Author: wrisa

instrumentation-genai/opentelemetry-instrumentation-langchain/src/opentelemetry/instrumentation/langchain/callback_handler.py

@@ -23,11 +23,7 @@
 from opentelemetry.semconv._incubating.attributes import (
     gen_ai_attributes as GenAI,
 )
-from opentelemetry.semconv.attributes import (
-    error_attributes as ErrorAttributes,
-)
 from opentelemetry.trace import Tracer
-from opentelemetry.trace.status import Status, StatusCode
 
 
 class OpenTelemetryLangChainCallbackHandler(BaseCallbackHandler):  # type: ignore[misc]
@@ -175,15 +171,4 @@ def on_llm_error(
         parent_run_id: Optional[UUID] = None,
         **kwargs: Any,
     ) -> None:
-        self._handle_error(error, run_id)
-
-    def _handle_error(self, error: BaseException, run_id: UUID):
-        span = self.span_manager.get_span(run_id)
-        if span is None:
-            # If the span does not exist, we cannot set the error status
-            return
-        span.set_status(Status(StatusCode.ERROR, str(error)))
-        span.set_attribute(
-            ErrorAttributes.ERROR_TYPE, type(error).__qualname__
-        )
-        self.span_manager.end_span(run_id)
+        self.span_manager.handle_error(error, run_id)

instrumentation-genai/opentelemetry-instrumentation-langchain/src/opentelemetry/instrumentation/langchain/span_manager.py

@@ -22,13 +22,16 @@
     gen_ai_attributes as GenAI,
 )
 from opentelemetry.trace import Span, SpanKind, Tracer, set_span_in_context
+from opentelemetry.semconv.attributes import (
+    error_attributes as ErrorAttributes,
+)
+from opentelemetry.trace.status import Status, StatusCode
 
 
 @dataclass
 class _SpanState:
     span: Span
     context: Context
-    start_time: float = field(default_factory=time.time)
     children: List[UUID] = field(default_factory=list)
 
 
@@ -100,3 +103,14 @@ def end_span(self, run_id: UUID) -> None:
     def get_span(self, run_id: UUID) -> Optional[Span]:
         state = self.spans.get(run_id)
         return state.span if state else None
+
+    def handle_error(self, error: BaseException, run_id: UUID):
+        span = self.get_span(run_id)
+        if span is None:
+            # If the span does not exist, we cannot set the error status
+            return
+        span.set_status(Status(StatusCode.ERROR, str(error)))
+        span.set_attribute(
+            ErrorAttributes.ERROR_TYPE, type(error).__qualname__
+        )
+        self.end_span(run_id)