Add test that refs are correctly set

Author: DylanRussell

util/opentelemetry-util-genai/src/opentelemetry/util/genai/_upload/completion_hook.py

@@ -203,15 +203,16 @@ def _do_upload(
     def on_completion(
         self,
         *,
-        inputs: list[types.InputMessage] | None = None,
-        outputs: list[types.OutputMessage] | None = None,
-        system_instruction: list[types.MessagePart] | None = None,
+        inputs: list[types.InputMessage],
+        outputs: list[types.OutputMessage],
+        system_instruction: list[types.MessagePart],
         span: Span | None = None,
         log_record: LogRecord | None = None,
         **kwargs: Any,
     ) -> None:
         if not any([inputs, outputs, system_instruction]):
             return
+        # An empty list will not be uploaded.
         completion = Completion(
             inputs=inputs or None,
             outputs=outputs or None,

util/opentelemetry-util-genai/tests/test_upload.py

@@ -163,10 +163,12 @@ def test_upload_then_shutdown(self):
         )
 
     def test_upload_when_inputs_outputs_empty(self):
+        record = LogRecord()
         self.hook.on_completion(
             inputs=[],
             outputs=[],
             system_instruction=FAKE_SYSTEM_INSTRUCTION,
+            log_record=record,
         )
         # all items should be consumed
         self.hook.shutdown()
@@ -176,6 +178,16 @@ def test_upload_when_inputs_outputs_empty(self):
             1,
             "should have uploaded 1 file",
         )
+        assert record.attributes is not None
+        for ref_key in [
+            "gen_ai.input.messages_ref",
+            "gen_ai.output.messages_ref",
+            "gen_ai.system_instructions_ref",
+        ]:
+            if ref_key == "gen_ai.system_instructions_ref":
+                self.assertIn(ref_key, record.attributes)
+            else:
+                self.assertNotIn(ref_key, record.attributes)
 
     def test_upload_blocked(self):
         with self.block_upload():