Skip to content

Commit 7d210b3

Browse files
committed
Fix function that finds events
1 parent 2281e70 commit 7d210b3

File tree

2 files changed

+20
-17
lines changed
  • instrumentation-genai/opentelemetry-instrumentation-google-genai

2 files changed

+20
-17
lines changed

instrumentation-genai/opentelemetry-instrumentation-google-genai/src/opentelemetry/instrumentation/google_genai/otel_wrapper.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,5 +88,7 @@ def log_response_content(self, attributes, body):
8888
self._log_event(event_name, attributes, body)
8989

9090
def _log_event(self, event_name, attributes, body):
91-
event = LogRecord(event_name=event_name, body=body, attributes=attributes)
91+
event = LogRecord(
92+
event_name=event_name, body=body, attributes=attributes
93+
)
9294
self._logger_provider.emit(event)

instrumentation-genai/opentelemetry-instrumentation-google-genai/tests/common/otel_mocker.py

Lines changed: 17 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
get_logger_provider,
2121
set_logger_provider,
2222
)
23-
from opentelemetry._logs import get_logger_provider, set_logger_provider
2423
from opentelemetry.metrics import get_meter_provider, set_meter_provider
2524
from opentelemetry.sdk._logs import LoggerProvider
2625
from opentelemetry.sdk._logs.export import (
@@ -77,6 +76,10 @@ def attributes(self):
7776
def body(self):
7877
return self._log_data.log_record.body
7978

79+
@property
80+
def event_name(self):
81+
return self._log_data.log_record.event_name
82+
8083
def __str__(self):
8184
return self._log_data.log_record.to_json()
8285

@@ -170,23 +173,21 @@ def assert_does_not_have_span_named(self, name):
170173
assert span is None, f"Found unexpected span named {name}"
171174

172175
def get_event_named(self, event_name):
173-
for event in self.get_finished_logs():
174-
event_name_attr = event.attributes.get("event.name")
175-
if event_name_attr is None:
176-
continue
177-
if event_name_attr == event_name:
178-
return event
179-
return None
176+
return next(
177+
(
178+
event
179+
for event in self.get_finished_logs()
180+
if event.event_name == event_name
181+
),
182+
None,
183+
)
180184

181185
def get_events_named(self, event_name):
182-
result = []
183-
for event in self.get_finished_logs():
184-
event_name_attr = event.attributes.get("event.name")
185-
if event_name_attr is None:
186-
continue
187-
if event_name_attr == event_name:
188-
result.append(event)
189-
return result
186+
return [
187+
event
188+
for event in self.get_finished_logs()
189+
if event.event_name == event_name
190+
]
190191

191192
def assert_has_event_named(self, name):
192193
event = self.get_event_named(name)

0 commit comments

Comments
 (0)