Respond to comments

Author: DylanRussell

cassettes/test_tool_events_no_content

@@ -16,7 +16,7 @@ OTEL_INSTRUMENTATION_GENAI_CAPTURE_MESSAGE_CONTENT=SPAN_AND_EVENT
 
 # Optional hook that will upload prompt and response content to some external destination.
 # For example fsspec.
-OTEL_INSTRUMENTATION_GENAI_COMPLETION_HOOK = "fsspec"
+OTEL_INSTRUMENTATION_GENAI_COMPLETION_HOOK = "upload"
 
 # Required if using a completion hook. The path to upload content to for example gs://my_bucket.
 OTEL_INSTRUMENTATION_GENAI_UPLOAD_BASE_PATH = "gs://my_bucket"

cassettes/test_tool_events_no_content.yaml

@@ -22,7 +22,7 @@ OTEL_INSTRUMENTATION_GENAI_CAPTURE_MESSAGE_CONTENT=SPAN_AND_EVENT
 
 # Optional hook that will upload prompt and response content to some external destination.
 # For example fsspec.
-OTEL_INSTRUMENTATION_GENAI_COMPLETION_HOOK = "fsspec"
+OTEL_INSTRUMENTATION_GENAI_COMPLETION_HOOK = "upload"
 
 # Required if using a completion hook. The path to upload content to for example gs://my_bucket.
 OTEL_INSTRUMENTATION_GENAI_UPLOAD_BASE_PATH = "gs://my_bucket"

instrumentation-genai/opentelemetry-instrumentation-vertexai/examples/manual/.env

@@ -193,7 +193,7 @@ def handle_response(
                     ]
                 if response:
                     outputs = convert_response_to_output_messages(response)
-                content = {
+                content_attributes = {
                     k: [asdict(x) for x in v]
                     for k, v in [
                         (
@@ -207,26 +207,25 @@ def handle_response(
                 }
                 if span.is_recording():
                     span.set_attributes(attributes)
-                    if capture_content in frozenset(
-                        [
-                            ContentCapturingMode.SPAN_AND_EVENT,
-                            ContentCapturingMode.SPAN_ONLY,
-                        ]
+                    if capture_content in (
+                        ContentCapturingMode.SPAN_AND_EVENT,
+                        ContentCapturingMode.SPAN_ONLY,
                     ):
                         span.set_attributes(
-                            {k: json.dumps(v) for k, v in content.items()}
+                            {
+                                k: json.dumps(v)
+                                for k, v in content_attributes.items()
+                            }
                         )
                 event = Event(
                     name="gen_ai.client.inference.operation.details",
                 )
                 event.attributes = attributes
-                if capture_content in frozenset(
-                    [
-                        ContentCapturingMode.SPAN_AND_EVENT,
-                        ContentCapturingMode.EVENT_ONLY,
-                    ]
+                if capture_content in (
+                    ContentCapturingMode.SPAN_AND_EVENT,
+                    ContentCapturingMode.EVENT_ONLY,
                 ):
-                    event.attributes |= content
+                    event.attributes |= content_attributes
                 self.event_logger.emit(event)
                 self.completion_hook.on_completion(
                     inputs=inputs,

instrumentation-genai/opentelemetry-instrumentation-vertexai/examples/zero-code/.env

@@ -199,7 +199,7 @@ def instrument_with_upload_hook(
     os.environ.update(
         {
             OTEL_SEMCONV_STABILITY_OPT_IN: "gen_ai_latest_experimental",
-            "OTEL_INSTRUMENTATION_GENAI_COMPLETION_HOOK": "fsspec_upload",
+            "OTEL_INSTRUMENTATION_GENAI_COMPLETION_HOOK": "upload",
             "OTEL_INSTRUMENTATION_GENAI_UPLOAD_BASE_PATH": "memory://",
             OTEL_INSTRUMENTATION_GENAI_CAPTURE_MESSAGE_CONTENT: "SPAN_AND_EVENT",
         }