Switch to Sha 256

Author: DylanRussell

util/opentelemetry-util-genai/src/opentelemetry/util/genai/_upload/completion_hook.py

@@ -15,7 +15,7 @@
 
 from __future__ import annotations
 
-import binascii
+import hashlib
 import logging
 import posixpath
 import threading
@@ -160,14 +160,13 @@ def _calculate_ref_path(
         # gen_ai.response.id from the active span.
         system_instruction_hash = None
         if all(isinstance(x, types.Text) for x in system_instruction):
-            # Get a checksum of the text.
-            system_instruction_hash = hex(
-                binascii.crc32(
-                    "\n".join(x.content for x in system_instruction).encode(  # pyright: ignore[reportUnknownMemberType, reportAttributeAccessIssue, reportUnknownArgumentType]
-                        "utf-8"
-                    )
-                )
-            )
+            # Get a hash of the text.
+            system_instruction_hash = hashlib.sha256(
+                "\n".join(x.content for x in system_instruction).encode(  # pyright: ignore[reportUnknownMemberType, reportAttributeAccessIssue, reportUnknownArgumentType]
+                    "utf-8"
+                ),
+                usedforsecurity=False,
+            ).hexdigest()
         uuid_str = str(uuid4())
         return CompletionRefs(
             inputs_ref=posixpath.join(

util/opentelemetry-util-genai/tests/test_upload.py

@@ -14,7 +14,7 @@
 
 
 # pylint: disable=import-outside-toplevel,no-name-in-module
-import binascii
+import hashlib
 import importlib
 import logging
 import sys
@@ -160,7 +160,7 @@ def test_upload_then_shutdown(self):
         # all items should be consumed
         self.hook.shutdown()
         # TODO: https://github.com/open-telemetry/opentelemetry-python-contrib/issues/3812 fix flaky test that requires sleep.
-        time.sleep(2)
+        time.sleep(0.5)
         self.assertEqual(
             self.mock_fs.open.call_count,
             3,
@@ -172,13 +172,10 @@ def test_system_insruction_is_hashed_to_avoid_reupload(self):
             types.Text(content="You are a helpful assistant."),
             types.Text(content="You will do your best."),
         ]
-        expected_hash = hex(
-            binascii.crc32(
-                "\n".join(x.content for x in system_instructions).encode(
-                    "utf-8"
-                )
-            )
-        )
+        expected_hash = hashlib.sha256(
+            "\n".join(x.content for x in system_instructions).encode("utf-8"),
+            usedforsecurity=False,
+        ).hexdigest()
         record = LogRecord()
         self.hook.on_completion(
             inputs=[],
@@ -187,7 +184,7 @@ def test_system_insruction_is_hashed_to_avoid_reupload(self):
             log_record=record,
         )
         # Wait a bit for file upload to finish..
-        time.sleep(0.5)
+        time.sleep(2)
         self.mock_fs.exists.return_value = True
         self.hook.on_completion(
             inputs=[],