Skip to content

Commit 8342416

Browse files
committed
Addressed comments
1 parent 87a8cee commit 8342416

File tree

1 file changed

+9
-8
lines changed
  • instrumentation/opentelemetry-instrumentation-flask/src/opentelemetry/instrumentation/flask

1 file changed

+9
-8
lines changed

instrumentation/opentelemetry-instrumentation-flask/src/opentelemetry/instrumentation/flask/__init__.py

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -351,10 +351,7 @@ def _wrapped_app(wrapped_app_environ, start_response):
351351
request_route = None
352352

353353
def _start_response(status, response_headers, *args, **kwargs):
354-
if flask.request and (
355-
excluded_urls is None
356-
or not excluded_urls.url_disabled(flask.request.url)
357-
):
354+
if _should_exclude_request(excluded_urls):
358355
nonlocal request_route
359356
request_route = flask.request.url_rule
360357

@@ -395,10 +392,7 @@ def _start_response(status, response_headers, *args, **kwargs):
395392
return start_response(status, response_headers, *args, **kwargs)
396393

397394
result = wsgi_app(wrapped_app_environ, _start_response)
398-
if flask.request and (
399-
excluded_urls is None
400-
or not excluded_urls.url_disabled(flask.request.url)
401-
):
395+
if _should_exclude_request(excluded_urls):
402396
duration_s = default_timer() - start
403397
if duration_histogram_old:
404398
duration_attrs_old = otel_wsgi._parse_duration_attrs(
@@ -426,6 +420,13 @@ def _start_response(status, response_headers, *args, **kwargs):
426420
active_requests_counter.add(-1, active_requests_count_attrs)
427421
return result
428422

423+
def _should_exclude_request(excluded_urls):
424+
if flask.request:
425+
return excluded_urls is None or not excluded_urls.url_disabled(
426+
flask.request.url
427+
)
428+
return False
429+
429430
return _wrapped_app
430431

431432

0 commit comments

Comments
 (0)