Remove pass of AWS env vars from tox.ini

Author: xrmx

instrumentation/opentelemetry-instrumentation-botocore/tests/README.md

@@ -0,0 +1,11 @@
+## Recording calls
+
+If you need to record calls you may need to export authentication variables and the default region as environment
+variables in order to have the code work properly.
+Since tox blocks environment variables by default you need to override its configuration to let them pass:
+
+```
+export TOX_OVERRIDE=testenv.pass_env=AWS_ACCESS_KEY_ID,AWS_SECRET_ACCESS_KEY,AWS_SESSION_TOKEN,AWS_DEFAULT_REGION
+```
+
+We are not adding it to tox.ini because of security concerns.

tox.ini

@@ -421,11 +421,6 @@ test_deps =
   opentelemetry-semantic-conventions@{env:CORE_REPO}\#egg=opentelemetry-semantic-conventions&subdirectory=opentelemetry-semantic-conventions
   opentelemetry-sdk@{env:CORE_REPO}\#egg=opentelemetry-sdk&subdirectory=opentelemetry-sdk
   opentelemetry-test-utils@{env:CORE_REPO}\#egg=opentelemetry-test-utils&subdirectory=tests/opentelemetry-test-utils
-pass_env =
-  AWS_ACCESS_KEY_ID
-  AWS_SECRET_ACCESS_KEY
-  AWS_SESSION_TOKEN
-  AWS_DEFAULT_REGION
 
 deps =
   lint: -r dev-requirements.txt