lint

Author: Liudmila Molkova

instrumentation/opentelemetry-instrumentation-openai-v2/src/opentelemetry/instrumentation/openai_v2/patch.py

@@ -33,7 +33,6 @@
     is_streaming,
     message_to_event,
     set_span_attribute,
-    silently_fail,
 )
 
 
@@ -86,7 +85,6 @@ def traced_method(wrapped, instance, args, kwargs):
     return traced_method
 
 
-@silently_fail
 def _set_response_attributes(
     span, result, event_logger: EventLogger, capture_content: bool
 ):

instrumentation/opentelemetry-instrumentation-openai-v2/src/opentelemetry/instrumentation/openai_v2/utils.py

@@ -12,7 +12,6 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-import logging
 from os import environ
 from typing import Optional, Union
 from urllib.parse import urlparse
@@ -32,35 +31,13 @@
     "OTEL_INSTRUMENTATION_OPENAI_CAPTURE_MESSAGE_CONTENT"
 )
 
-
 def is_content_enabled() -> bool:
     capture_content = environ.get(
         OTEL_INSTRUMENTATION_OPENAI_CAPTURE_MESSAGE_CONTENT, None
     )
 
     return bool(capture_content)
 
-
-def silently_fail(func):
-    """
-    A decorator that catches exceptions thrown by the decorated function and logs them as warnings.
-    """
-
-    logger = logging.getLogger(func.__module__)
-
-    def wrapper(*args, **kwargs):
-        try:
-            return func(*args, **kwargs)
-        except Exception as exception:  # pylint: disable=broad-exception-caught
-            logger.warning(
-                "Failed to execute %s, error: %s",
-                func.__name__,
-                str(exception),
-            )
-
-    return wrapper
-
-
 def extract_tool_calls(item, capture_content):
     tool_calls = get_property_value(item, "tool_calls")
     if tool_calls is None:

instrumentation/opentelemetry-instrumentation-openai-v2/tests/test_chat_completions.py

@@ -1,3 +1,18 @@
+# Copyright The OpenTelemetry Authors
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+# pylint: disable=too-many-locals
+
 from typing import Optional
 
 import pytest
@@ -709,7 +724,7 @@ def remove_none_values(body):
     for key, value in body.items():
         if value is None:
             continue
-        elif isinstance(value, dict):
+        if isinstance(value, dict):
             result[key] = remove_none_values(value)
         elif isinstance(value, list):
             result[key] = [remove_none_values(i) for i in value]