Skip to content

Commit 8ce86fc

Browse files
committed
Adding tests, updating changelog
1 parent 4b112fb commit 8ce86fc

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1919

2020
### Added
2121
- `opentelemetry-instrumentation-aiohttp-client` Add support for HTTP metrics
22-
([#](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/))
22+
([#3517](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3517))
2323

2424

2525
## Version 1.33.0/0.54b0 (2025-05-09)

instrumentation/opentelemetry-instrumentation-aiohttp-client/tests/test_aiohttp_client_integration.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@
3030
from opentelemetry import trace as trace_api
3131
from opentelemetry.instrumentation import aiohttp_client
3232
from opentelemetry.instrumentation._semconv import (
33+
HTTP_DURATION_HISTOGRAM_BUCKETS_NEW,
34+
HTTP_DURATION_HISTOGRAM_BUCKETS_OLD,
3335
OTEL_SEMCONV_STABILITY_OPT_IN,
3436
_OpenTelemetrySemanticConventionStability,
3537
_StabilityMode,
@@ -164,6 +166,10 @@ def test_status_codes(self):
164166
HTTP_METHOD: "GET",
165167
},
166168
)
169+
self.assertEqual(
170+
duration_data_point.explicit_bounds,
171+
HTTP_DURATION_HISTOGRAM_BUCKETS_OLD,
172+
)
167173
index += 1
168174

169175
def test_status_codes_new_semconv(self):
@@ -206,6 +212,10 @@ def test_status_codes_new_semconv(self):
206212
duration_data_point.attributes.get(ERROR_TYPE),
207213
str(status_code.value),
208214
)
215+
self.assertEqual(
216+
duration_data_point.explicit_bounds,
217+
HTTP_DURATION_HISTOGRAM_BUCKETS_NEW,
218+
)
209219
index += 1
210220

211221
def test_status_codes_both_semconv(self):

0 commit comments

Comments
 (0)