Move const values to a constants file.

Author: JacksonWeber

instrumentation/opentelemetry-instrumentation-requests/src/opentelemetry/instrumentation/requests/__init__.py

@@ -124,6 +124,10 @@ def response_hook(span, request_obj, response):
     _StabilityMode,
 )
 from opentelemetry.instrumentation.instrumentor import BaseInstrumentor
+from opentelemetry.instrumentation.requests.constants import (
+    BOT_PATTERNS,
+    TEST_PATTERNS,
+)
 from opentelemetry.instrumentation.requests.package import _instruments
 from opentelemetry.instrumentation.requests.semconv import (
     ATTR_USER_AGENT_SYNTHETIC_TYPE,
@@ -162,17 +166,6 @@ def response_hook(span, request_obj, response):
 _RequestHookT = Optional[Callable[[Span, PreparedRequest], None]]
 _ResponseHookT = Optional[Callable[[Span, PreparedRequest, Response], None]]
 
-# Test patterns to detect (case-insensitive)
-_TEST_PATTERNS = [
-    "alwayson",
-]
-
-# Bot patterns to detect (case-insensitive)
-_BOT_PATTERNS = [
-    "googlebot",
-    "bingbot",
-]
-
 
 def _detect_synthetic_user_agent(user_agent: str) -> Optional[str]:
     """
@@ -182,8 +175,8 @@ def _detect_synthetic_user_agent(user_agent: str) -> Optional[str]:
         user_agent: The user agent string to analyze
 
     Returns:
-        USER_AGENT_SYNTHETIC_TYPE_VALUE_TEST if user agent contains any pattern from _TEST_PATTERNS
-        USER_AGENT_SYNTHETIC_TYPE_VALUE_BOT if user agent contains any pattern from _BOT_PATTERNS
+        USER_AGENT_SYNTHETIC_TYPE_VALUE_TEST if user agent contains any pattern from TEST_PATTERNS
+        USER_AGENT_SYNTHETIC_TYPE_VALUE_BOT if user agent contains any pattern from BOT_PATTERNS
         None otherwise
 
     Note: Test patterns take priority over bot patterns.
@@ -193,11 +186,9 @@ def _detect_synthetic_user_agent(user_agent: str) -> Optional[str]:
 
     user_agent_lower = user_agent.lower()
 
-    if any(
-        test_pattern in user_agent_lower for test_pattern in _TEST_PATTERNS
-    ):
+    if any(test_pattern in user_agent_lower for test_pattern in TEST_PATTERNS):
         return USER_AGENT_SYNTHETIC_TYPE_VALUE_TEST
-    if any(bot_pattern in user_agent_lower for bot_pattern in _BOT_PATTERNS):
+    if any(bot_pattern in user_agent_lower for bot_pattern in BOT_PATTERNS):
         return USER_AGENT_SYNTHETIC_TYPE_VALUE_BOT
 
     return None

instrumentation/opentelemetry-instrumentation-requests/src/opentelemetry/instrumentation/requests/constants.py

@@ -0,0 +1,34 @@
+# Copyright The OpenTelemetry Authors
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+"""
+Constants for OpenTelemetry requests instrumentation.
+
+This module contains configuration constants and pattern definitions used
+by the requests instrumentation for various features like synthetic user
+agent detection.
+"""
+
+# Test patterns to detect in user agent strings (case-insensitive)
+# These patterns indicate synthetic test traffic
+TEST_PATTERNS = [
+    "alwayson",
+]
+
+# Bot patterns to detect in user agent strings (case-insensitive)
+# These patterns indicate automated bot traffic
+BOT_PATTERNS = [
+    "googlebot",
+    "bingbot",
+]