Skip to content

Commit 94ee68b

Browse files
committed
Remove unneeded accessor from OTelWrapper.
1 parent a761858 commit 94ee68b

File tree

2 files changed

+2
-18
lines changed

2 files changed

+2
-18
lines changed

instrumentation-genai/opentelemetry-instrumentation-google-genai/src/opentelemetry/instrumentation/google_genai/generate_content.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,6 @@ def finalize_processing(self):
253253
)
254254
self._record_token_usage_metric()
255255
self._record_duration_metric()
256-
self._otel_wrapper.done()
257256

258257
def _maybe_update_token_counts(self, response: GenerateContentResponse):
259258
input_tokens = _get_response_property(
@@ -327,7 +326,7 @@ def _maybe_log_user_prompt(
327326
# a role supplied (and it looks like there could be cases where there
328327
# is more than one role present in the supplied contents)?
329328
#
330-
# See also: "TODOS.md"
329+
# See also: "TODOS.md"
331330
self._otel_wrapper.log_user_prompt(
332331
attributes={
333332
gen_ai_attributes.GEN_AI_SYSTEM: self._genai_system,

instrumentation-genai/opentelemetry-instrumentation-google-genai/src/opentelemetry/instrumentation/google_genai/otel_wrapper.py

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -64,21 +64,6 @@ def from_providers(tracer_provider, event_logger_provider, meter_provider):
6464
def start_as_current_span(self, *args, **kwargs):
6565
return self._tracer.start_as_current_span(*args, **kwargs)
6666

67-
def done(self):
68-
pass
69-
70-
@property
71-
def tracer(self):
72-
return self._tracer
73-
74-
@property
75-
def event_logger(self):
76-
return self._event_logger
77-
78-
@property
79-
def meter(self):
80-
return self._meter
81-
8267
@property
8368
def operation_duration_metric(self):
8469
return self._operation_duration_metric
@@ -104,4 +89,4 @@ def log_response_content(self, attributes, body):
10489

10590
def _log_event(self, event_name, attributes, body):
10691
event = Event(event_name, body=body, attributes=attributes)
107-
self.event_logger.emit(event)
92+
self._event_logger.emit(event)

0 commit comments

Comments
 (0)