review comments

Author: Liudmila Molkova

instrumentation/opentelemetry-instrumentation-openai-v2/src/opentelemetry/instrumentation/openai_v2/patch.py

@@ -54,9 +54,7 @@ def traced_method(wrapped, instance, args, kwargs):
             if span.is_recording():
                 for message in kwargs.get("messages", []):
                     event_logger.emit(
-                        message_to_event(
-                            message, span.get_span_context(), capture_content
-                        )
+                        message_to_event(message, capture_content)
                     )
 
             try:
@@ -95,11 +93,7 @@ def _set_response_attributes(
     if getattr(result, "choices", None):
         choices = result.choices
         for choice in choices:
-            event_logger.emit(
-                choice_to_event(
-                    choice, span.get_span_context(), capture_content
-                )
-            )
+            event_logger.emit(choice_to_event(choice, capture_content))
 
         finish_reasons = []
         for choice in choices:
@@ -268,6 +262,8 @@ def cleanup(self):
                 event_attributes = {
                     GenAIAttributes.GEN_AI_SYSTEM: GenAIAttributes.GenAiSystemValues.OPENAI.value
                 }
+
+                # this span is not current, so we need to manually set the context on event
                 span_ctx = self.span.get_span_context()
                 self.event_logger.emit(
                     Event(

instrumentation/opentelemetry-instrumentation-openai-v2/src/opentelemetry/instrumentation/openai_v2/utils.py

@@ -100,7 +100,7 @@ def get_property_value(obj, property_name):
     return getattr(obj, property_name, None)
 
 
-def message_to_event(message, span_ctx, capture_content):
+def message_to_event(message, capture_content):
     attributes = {
         GenAIAttributes.GEN_AI_SYSTEM: GenAIAttributes.GenAiSystemValues.OPENAI.value
     }
@@ -123,13 +123,10 @@ def message_to_event(message, span_ctx, capture_content):
         name=f"gen_ai.{role}.message",
         attributes=attributes,
         body=body if body else None,
-        trace_id=span_ctx.trace_id,
-        span_id=span_ctx.span_id,
-        trace_flags=span_ctx.trace_flags,
     )
 
 
-def choice_to_event(choice, span_ctx, capture_content):
+def choice_to_event(choice, capture_content):
     attributes = {
         GenAIAttributes.GEN_AI_SYSTEM: GenAIAttributes.GenAiSystemValues.OPENAI.value
     }
@@ -157,9 +154,6 @@ def choice_to_event(choice, span_ctx, capture_content):
         name="gen_ai.choice",
         attributes=attributes,
         body=body,
-        trace_id=span_ctx.trace_id,
-        span_id=span_ctx.span_id,
-        trace_flags=span_ctx.trace_flags,
     )