cleanup: remove redundant pylint disable comments for attribute-defined-outside-init

forafox · forafox · commit 985b02f96973 · 2025-10-16T00:42:14.000+03:00
diff --git a/instrumentation/opentelemetry-instrumentation-asyncio/src/opentelemetry/instrumentation/asyncio/__init__.py b/instrumentation/opentelemetry-instrumentation-asyncio/src/opentelemetry/instrumentation/asyncio/__init__.py
@@ -132,7 +132,6 @@ def instrumentation_dependencies(self) -> Collection[str]:
         return _instruments
 
     def _instrument(self, **kwargs):
-        # pylint: disable=attribute-defined-outside-init
         self._tracer = get_tracer(
             __name__, __version__, kwargs.get("tracer_provider")
         )
diff --git a/instrumentation/opentelemetry-instrumentation-aws-lambda/src/opentelemetry/instrumentation/aws_lambda/__init__.py b/instrumentation/opentelemetry-instrumentation-aws-lambda/src/opentelemetry/instrumentation/aws_lambda/__init__.py
@@ -459,7 +459,6 @@ def _instrument(self, **kwargs):
                 )
             )
             return
-        # pylint: disable=attribute-defined-outside-init
         (
             self._wrapped_module_name,
             self._wrapped_function_name,
diff --git a/instrumentation/opentelemetry-instrumentation-boto/src/opentelemetry/instrumentation/boto/__init__.py b/instrumentation/opentelemetry-instrumentation-boto/src/opentelemetry/instrumentation/boto/__init__.py
@@ -92,7 +92,6 @@ def _instrument(self, **kwargs):
         # For example EC2 uses AWSQueryConnection and S3 uses
         # AWSAuthConnection
 
-        # pylint: disable=attribute-defined-outside-init
         self._tracer = get_tracer(
             __name__,
             __version__,
diff --git a/instrumentation/opentelemetry-instrumentation-boto3sqs/src/opentelemetry/instrumentation/boto3sqs/__init__.py b/instrumentation/opentelemetry-instrumentation-boto3sqs/src/opentelemetry/instrumentation/boto3sqs/__init__.py
@@ -93,7 +93,6 @@ def set(self, carrier: CarrierT, key: str, value: str) -> None:
 boto3sqs_setter = Boto3SQSSetter()
 
 
-# pylint: disable=attribute-defined-outside-init
 class Boto3SQSInstrumentor(BaseInstrumentor):
     received_messages_spans: Dict[str, Span] = {}
     current_span_related_to_token: Span = None
diff --git a/instrumentation/opentelemetry-instrumentation-botocore/src/opentelemetry/instrumentation/botocore/__init__.py b/instrumentation/opentelemetry-instrumentation-botocore/src/opentelemetry/instrumentation/botocore/__init__.py
@@ -135,8 +135,6 @@ def instrumentation_dependencies(self) -> Collection[str]:
         return _instruments
 
     def _instrument(self, **kwargs):
-        # pylint: disable=attribute-defined-outside-init
-
         # tracers are lazy initialized per-extension in _get_tracer
         self._tracers = {}
         # loggers are lazy initialized per-extension in _get_logger
diff --git a/instrumentation/opentelemetry-instrumentation-botocore/src/opentelemetry/instrumentation/botocore/extensions/bedrock.py b/instrumentation/opentelemetry-instrumentation-botocore/src/opentelemetry/instrumentation/botocore/extensions/bedrock.py
@@ -471,7 +471,6 @@ def before_service_call(
                 span.update_name(f"{operation_name} {request_model}")
 
         # this is used to calculate the operation duration metric, duration may be skewed by request_hook
-        # pylint: disable=attribute-defined-outside-init
         self._operation_start = default_timer()
 
     # pylint: disable=no-self-use,too-many-locals
diff --git a/instrumentation/opentelemetry-instrumentation-confluent-kafka/src/opentelemetry/instrumentation/confluent_kafka/__init__.py b/instrumentation/opentelemetry-instrumentation-confluent-kafka/src/opentelemetry/instrumentation/confluent_kafka/__init__.py
@@ -228,7 +228,6 @@ class ConfluentKafkaInstrumentor(BaseInstrumentor):
     See `BaseInstrumentor`
     """
 
-    # pylint: disable=attribute-defined-outside-init
     @staticmethod
     def instrument_producer(
         producer: Producer, tracer_provider=None
diff --git a/instrumentation/opentelemetry-instrumentation-fastapi/tests/test_fastapi_instrumentation.py b/instrumentation/opentelemetry-instrumentation-fastapi/tests/test_fastapi_instrumentation.py
@@ -2054,7 +2054,6 @@ async def _(*_):
         )
 
 
-# pylint: disable=attribute-defined-outside-init
 class TestFastAPIFallback(TestBaseFastAPI):
     @pytest.fixture(autouse=True)
     def inject_fixtures(self, caplog):
diff --git a/instrumentation/opentelemetry-instrumentation-flask/tests/base_test.py b/instrumentation/opentelemetry-instrumentation-flask/tests/base_test.py
@@ -118,5 +118,4 @@ def excluded2_endpoint():
             self._repeat_custom_response_headers
         )
 
-        # pylint: disable=attribute-defined-outside-init
         self.client = Client(self.app, Response)
diff --git a/instrumentation/opentelemetry-instrumentation-flask/tests/test_automatic.py b/instrumentation/opentelemetry-instrumentation-flask/tests/test_automatic.py
@@ -51,7 +51,6 @@ def test_uninstrument(self):
         self.app = flask.Flask(__name__)
 
         self.app.route("/hello/<int:helloid>")(self._hello_endpoint)
-        # pylint: disable=attribute-defined-outside-init
         self.client = Client(self.app, Response)
 
         resp = self.client.get("/hello/123")
@@ -88,7 +87,6 @@ def test_no_op_tracer_provider(self):
 
         self.app = flask.Flask(__name__)
         self.app.route("/hello/<int:helloid>")(self._hello_endpoint)
-        # pylint: disable=attribute-defined-outside-init
         self.client = Client(self.app, Response)
         self.client.get("/hello/123")
 
diff --git a/instrumentation/opentelemetry-instrumentation-logging/tests/test_logging.py b/instrumentation/opentelemetry-instrumentation-logging/tests/test_logging.py
@@ -43,8 +43,7 @@ def get_tracer(  # pylint: disable=no-self-use
 class TestLoggingInstrumentorProxyTracerProvider(TestBase):
     @pytest.fixture(autouse=True)
     def inject_fixtures(self, caplog):
-        self.caplog = caplog  # pylint: disable=attribute-defined-outside-init
-
+        self.caplog = caplog
     def setUp(self):
         super().setUp()
         LoggingInstrumentor().instrument(tracer_provider=FakeTracerProvider())
@@ -72,8 +71,7 @@ def log_hook(span, record):
 class TestLoggingInstrumentor(TestBase):
     @pytest.fixture(autouse=True)
     def inject_fixtures(self, caplog):
-        self.caplog = caplog  # pylint: disable=attribute-defined-outside-init
-
+        self.caplog = caplog
     def setUp(self):
         super().setUp()
         LoggingInstrumentor().instrument()
diff --git a/instrumentation/opentelemetry-instrumentation-pika/src/opentelemetry/instrumentation/pika/pika_instrumentor.py b/instrumentation/opentelemetry-instrumentation-pika/src/opentelemetry/instrumentation/pika/pika_instrumentor.py
@@ -53,7 +53,6 @@ def _consumer_callback_attribute_name() -> str:
 class PikaInstrumentor(BaseInstrumentor):  # type: ignore
     CONSUMER_CALLBACK_ATTR = _consumer_callback_attribute_name()
 
-    # pylint: disable=attribute-defined-outside-init
     @staticmethod
     def _instrument_channel_consumers(
         channel: Union[BlockingChannel, Channel],
diff --git a/instrumentation/opentelemetry-instrumentation-pymemcache/tests/test_pymemcache.py b/instrumentation/opentelemetry-instrumentation-pymemcache/tests/test_pymemcache.py
@@ -67,7 +67,6 @@ def tearDown(self):
         PymemcacheInstrumentor().uninstrument()
 
     def make_client(self, mock_socket_values, **kwargs):
-        # pylint: disable=attribute-defined-outside-init
         self.client = pymemcache.client.base.Client(
             (TEST_HOST, TEST_PORT), **kwargs
         )
@@ -554,7 +553,6 @@ def make_client(self, *mock_socket_values, **kwargs):
         # pylint: disable=import-outside-toplevel
         from pymemcache.client.hash import HashClient
 
-        # pylint: disable=attribute-defined-outside-init
         self.client = HashClient([], **kwargs)
         ip = TEST_HOST
 
diff --git a/instrumentation/opentelemetry-instrumentation-pyramid/tests/pyramid_base_test.py b/instrumentation/opentelemetry-instrumentation-pyramid/tests/pyramid_base_test.py
@@ -71,5 +71,4 @@ def excluded2_endpoint(request):
             route_name="custom_response_headers",
         )
 
-        # pylint: disable=attribute-defined-outside-init
         self.client = Client(config.make_wsgi_app(), TestResponse)
diff --git a/instrumentation/opentelemetry-instrumentation-remoulade/src/opentelemetry/instrumentation/remoulade/__init__.py b/instrumentation/opentelemetry-instrumentation-remoulade/src/opentelemetry/instrumentation/remoulade/__init__.py
@@ -177,7 +177,6 @@ def instrumentation_dependencies(self) -> Collection[str]:
     def _instrument(self, **kwargs):
         tracer_provider = kwargs.get("tracer_provider")
 
-        # pylint: disable=attribute-defined-outside-init
         self._tracer = trace.get_tracer(
             __name__,
             __version__,
diff --git a/instrumentation/opentelemetry-instrumentation-sqlalchemy/tests/test_sqlalchemy.py b/instrumentation/opentelemetry-instrumentation-sqlalchemy/tests/test_sqlalchemy.py
@@ -37,7 +37,7 @@
 class TestSqlalchemyInstrumentation(TestBase):
     @pytest.fixture(autouse=True)
     def inject_fixtures(self, caplog):
-        self.caplog = caplog  # pylint: disable=attribute-defined-outside-init
+        self.caplog = caplog
 
     def tearDown(self):
         super().tearDown()
diff --git a/instrumentation/opentelemetry-instrumentation-sqlalchemy/tests/test_sqlcommenter.py b/instrumentation/opentelemetry-instrumentation-sqlalchemy/tests/test_sqlcommenter.py
@@ -29,7 +29,7 @@
 class TestSqlalchemyInstrumentationWithSQLCommenter(TestBase):
     @pytest.fixture(autouse=True)
     def inject_fixtures(self, caplog):
-        self.caplog = caplog  # pylint: disable=attribute-defined-outside-init
+        self.caplog = caplog
 
     def tearDown(self):
         super().tearDown()
diff --git a/instrumentation/opentelemetry-instrumentation-tortoiseorm/src/opentelemetry/instrumentation/tortoiseorm/__init__.py b/instrumentation/opentelemetry-instrumentation-tortoiseorm/src/opentelemetry/instrumentation/tortoiseorm/__init__.py
@@ -95,7 +95,6 @@ def _instrument(self, **kwargs):
             None
         """
         tracer_provider = kwargs.get("tracer_provider")
-        # pylint: disable=attribute-defined-outside-init
         self._tracer = trace.get_tracer(
             __name__,
             __version__,

Original file line number	Diff line number	Diff line change
`@@ -132,7 +132,6 @@ def instrumentation_dependencies(self) -> Collection[str]:`
`132`	`132`	`return _instruments`
`133`	`133`
`134`	`134`	`def _instrument(self, **kwargs):`
`135`		`- # pylint: disable=attribute-defined-outside-init`
`136`	`135`	`self._tracer = get_tracer(`
`137`	`136`	`__name__, __version__, kwargs.get("tracer_provider")`
`138`	`137`	`)`
Original file line number	Diff line number	Diff line change
`@@ -459,7 +459,6 @@ def _instrument(self, **kwargs):`
`459`	`459`	`)`
`460`	`460`	`)`
`461`	`461`	`return`
`462`		`- # pylint: disable=attribute-defined-outside-init`
`463`	`462`	`(`
`464`	`463`	`self._wrapped_module_name,`
`465`	`464`	`self._wrapped_function_name,`
Original file line number	Diff line number	Diff line change
`@@ -2054,7 +2054,6 @@ async def _(*_):`
`2054`	`2054`	`)`
`2055`	`2055`
`2056`	`2056`
`2057`		`-# pylint: disable=attribute-defined-outside-init`
`2058`	`2057`	`class TestFastAPIFallback(TestBaseFastAPI):`
`2059`	`2058`	`@pytest.fixture(autouse=True)`
`2060`	`2059`	`def inject_fixtures(self, caplog):`
Original file line number	Diff line number	Diff line change
`@@ -118,5 +118,4 @@ def excluded2_endpoint():`
`118`	`118`	`self._repeat_custom_response_headers`
`119`	`119`	`)`
`120`	`120`
`121`		`- # pylint: disable=attribute-defined-outside-init`
`122`	`121`	`self.client = Client(self.app, Response)`