opentelemetry-instrumentation-urllib3: add explicit http duration buckets for stable semconv

Author: xrmx

instrumentation/opentelemetry-instrumentation-urllib3/src/opentelemetry/instrumentation/urllib3/__init__.py

@@ -103,6 +103,7 @@ def response_hook(
 import wrapt
 
 from opentelemetry.instrumentation._semconv import (
+    HTTP_DURATION_HISTOGRAM_BUCKETS_NEW,
     _client_duration_attrs_new,
     _client_duration_attrs_old,
     _filter_semconv_duration_attrs,
@@ -267,6 +268,7 @@ def _instrument(self, **kwargs):
                 name=HTTP_CLIENT_REQUEST_DURATION,
                 unit="s",
                 description="Duration of HTTP client requests.",
+                explicit_bucket_boundaries_advisory=HTTP_DURATION_HISTOGRAM_BUCKETS_NEW,
             )
             # http.client.request.body.size histogram
             request_size_histogram_new = create_http_client_request_body_size(

instrumentation/opentelemetry-instrumentation-urllib3/tests/test_urllib3_metrics.py

@@ -22,6 +22,7 @@
 from urllib3 import encode_multipart_formdata
 
 from opentelemetry.instrumentation._semconv import (
+    HTTP_DURATION_HISTOGRAM_BUCKETS_NEW,
     OTEL_SEMCONV_STABILITY_OPT_IN,
     _OpenTelemetrySemanticConventionStability,
 )
@@ -169,6 +170,7 @@ def test_basic_metrics_new_semconv(self):
                     max_data_point=duration_s,
                     min_data_point=duration_s,
                     attributes=attrs_new,
+                    explicit_bounds=HTTP_DURATION_HISTOGRAM_BUCKETS_NEW,
                 )
             ],
             est_value_delta=40 / 1000,
@@ -258,6 +260,7 @@ def test_basic_metrics_both_semconv(self):
                     max_data_point=duration_s,
                     min_data_point=duration_s,
                     attributes=attrs_new,
+                    explicit_bounds=HTTP_DURATION_HISTOGRAM_BUCKETS_NEW,
                 )
             ],
             est_value_delta=40 / 1000,
@@ -451,6 +454,7 @@ def test_basic_metrics_nonstandard_http_method_new_semconv(self):
                     max_data_point=duration_s,
                     min_data_point=duration_s,
                     attributes=attrs_new,
+                    explicit_bounds=HTTP_DURATION_HISTOGRAM_BUCKETS_NEW,
                 )
             ],
             est_value_delta=40 / 1000,