ruff formatting

Author: wrisa

instrumentation-genai/opentelemetry-instrumentation-langchain/src/opentelemetry/instrumentation/langchain/span_manager.py

@@ -17,15 +17,10 @@
 from typing import Dict, List, Optional
 from uuid import UUID
 
-from langchain_core.callbacks import BaseCallbackHandler  # type: ignore
-from langchain_core.messages import BaseMessage  # type: ignore
-from langchain_core.outputs import LLMResult  # type: ignore
-
 from opentelemetry.context import Context, get_current
 from opentelemetry.semconv._incubating.attributes import (
     gen_ai_attributes as GenAI,
 )
-
 from opentelemetry.trace import Span, SpanKind, Tracer, set_span_in_context
 
 
@@ -36,6 +31,7 @@ class _SpanState:
     start_time: float = field(default_factory=time.time)
     children: List[UUID] = field(default_factory=list)
 
+
 class SpanManager:
     def __init__(
         self,
@@ -102,4 +98,4 @@ def end_span(self, run_id: UUID) -> None:
         state.span.end()
 
     def get_span(self, run_id: UUID) -> Span:
-        return self.spans[run_id].span
+        return self.spans[run_id].span

instrumentation-genai/opentelemetry-instrumentation-langchain/tests/test_span_manager.py

@@ -2,13 +2,13 @@
 import uuid
 
 import pytest
-from opentelemetry.trace import SpanKind, get_tracer
-from opentelemetry.trace.span import Span
 
 from opentelemetry.instrumentation.langchain.span_manager import (
     SpanManager,
     _SpanState,
 )
+from opentelemetry.trace import SpanKind, get_tracer
+from opentelemetry.trace.span import Span
 
 
 class TestSpanManager:
@@ -28,8 +28,9 @@ def handler(self, tracer):
             (uuid.uuid4(), True),  # Parent in spans
         ],
     )
-
-    def test_create_span(self, handler, tracer, parent_run_id, parent_in_spans):
+    def test_create_span(
+        self, handler, tracer, parent_run_id, parent_in_spans
+    ):
         # Arrange
         run_id = uuid.uuid4()
         span_name = "test_span"
@@ -40,17 +41,25 @@ def test_create_span(self, handler, tracer, parent_run_id, parent_in_spans):
         # Setup parent if needed
         if parent_run_id is not None and parent_in_spans:
             parent_mock_span = unittest.mock.Mock(spec=Span)
-            handler.spans[parent_run_id] = _SpanState(span=parent_mock_span, context=None)
+            handler.spans[parent_run_id] = _SpanState(
+                span=parent_mock_span, context=None
+            )
 
-        with unittest.mock.patch.object(
-            tracer, "start_span", return_value=mock_span
-        ) as mock_start_span, unittest.mock.patch(
-            "opentelemetry.instrumentation.langchain.span_manager.set_span_in_context"
-        ) as mock_set_span_in_context, unittest.mock.patch(
-            "opentelemetry.instrumentation.langchain.span_manager.get_current"
-        ) as mock_get_current:
+        with (
+            unittest.mock.patch.object(
+                tracer, "start_span", return_value=mock_span
+            ) as mock_start_span,
+            unittest.mock.patch(
+                "opentelemetry.instrumentation.langchain.span_manager.set_span_in_context"
+            ) as mock_set_span_in_context,
+            unittest.mock.patch(
+                "opentelemetry.instrumentation.langchain.span_manager.get_current"
+            ) as mock_get_current,
+        ):
             # Act
-            result = handler.create_span(run_id, parent_run_id, span_name, kind)
+            result = handler.create_span(
+                run_id, parent_run_id, span_name, kind
+            )
 
             # Assert
             assert result == mock_span
@@ -59,11 +68,17 @@ def test_create_span(self, handler, tracer, parent_run_id, parent_in_spans):
 
             # Verify parent-child relationship
             if parent_run_id is not None and parent_in_spans:
-                mock_set_span_in_context.assert_called_once_with(handler.spans[parent_run_id].span)
+                mock_set_span_in_context.assert_called_once_with(
+                    handler.spans[parent_run_id].span
+                )
                 mock_start_span.assert_called_once_with(
-                    name=span_name, kind=kind, context=mock_set_span_in_context.return_value
+                    name=span_name,
+                    kind=kind,
+                    context=mock_set_span_in_context.return_value,
                 )
                 assert run_id in handler.spans[parent_run_id].children
             else:
-                mock_start_span.assert_called_once_with(name=span_name, kind=kind)
-                mock_set_span_in_context.assert_not_called()
+                mock_start_span.assert_called_once_with(
+                    name=span_name, kind=kind
+                )
+                mock_set_span_in_context.assert_not_called()