Please pylint

Author: xrmx

instrumentation/opentelemetry-instrumentation-system-metrics/tests/test_system_metrics.py

@@ -12,7 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-# pylint: disable=protected-access
+# pylint: disable=protected-access,too-many-lines
 
 import sys
 from collections import namedtuple
@@ -235,14 +235,28 @@ def _assert_metrics(self, observer_name, reader, expected):
                                 assertions += 1
         self.assertEqual(len(expected), assertions)
 
-    def _test_metrics(self, observer_name, expected):
+    @staticmethod
+    def _setup_instrumentor() -> InMemoryMetricReader:
         reader = InMemoryMetricReader()
         meter_provider = MeterProvider(metric_readers=[reader])
 
         system_metrics = SystemMetricsInstrumentor()
         system_metrics.instrument(meter_provider=meter_provider)
+        return reader
+
+    def _test_metrics(self, observer_name, expected):
+        reader = self._setup_instrumentor()
         self._assert_metrics(observer_name, reader, expected)
 
+    def _assert_metrics_not_found(self, observer_name):
+        reader = self._setup_instrumentor()
+        seen_metrics = set()
+        for resource_metrics in reader.get_metrics_data().resource_metrics:
+            for scope_metrics in resource_metrics.scope_metrics:
+                for metric in scope_metrics.metrics:
+                    seen_metrics.add(metric.name)
+        self.assertNotIn(observer_name, seen_metrics)
+
     # This patch is added here to stop psutil from raising an exception
     # because we're patching cpu_times
     # pylint: disable=unused-argument
@@ -861,17 +875,7 @@ def test_context_switches_not_implemented_error(
     ):
         mock_process_num_ctx_switches.side_effect = NotImplementedError
 
-        reader = InMemoryMetricReader()
-        meter_provider = MeterProvider(metric_readers=[reader])
-        system_metrics = SystemMetricsInstrumentor()
-        system_metrics.instrument(meter_provider=meter_provider)
-
-        seen_metrics = set()
-        for resource_metrics in reader.get_metrics_data().resource_metrics:
-            for scope_metrics in resource_metrics.scope_metrics:
-                for metric in scope_metrics.metrics:
-                    seen_metrics.add(metric.name)
-        self.assertNotIn("process.context_switches", seen_metrics)
+        self._assert_metrics_not_found("process.context_switches")
 
     @mock.patch("psutil.Process.num_threads")
     def test_thread_count(self, mock_process_thread_num):
@@ -971,19 +975,8 @@ def test_runtime_context_switches_not_implemented_error(
     ):
         mock_process_num_ctx_switches.side_effect = NotImplementedError
 
-        reader = InMemoryMetricReader()
-        meter_provider = MeterProvider(metric_readers=[reader])
-        system_metrics = SystemMetricsInstrumentor()
-        system_metrics.instrument(meter_provider=meter_provider)
-
-        seen_metrics = set()
-        for resource_metrics in reader.get_metrics_data().resource_metrics:
-            for scope_metrics in resource_metrics.scope_metrics:
-                for metric in scope_metrics.metrics:
-                    seen_metrics.add(metric.name)
-        self.assertNotIn(
+        self._assert_metrics_not_found(
             f"process.runtime.{self.implementation}.context_switches",
-            seen_metrics,
         )
 
     @mock.patch("psutil.Process.num_threads")