Skip to content

Commit ab1247d

Browse files
committed
Do not keep task id reference indefinitely
1 parent aa0579d commit ab1247d

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

instrumentation/opentelemetry-instrumentation-celery/src/opentelemetry/instrumentation/celery/__init__.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -362,6 +362,7 @@ def _record_histograms(self, task_id, metric_attributes):
362362
self.task_id_to_start_time.get(task_id),
363363
attributes=metric_attributes,
364364
)
365+
self.task_id_to_start_time.pop(task_id, None)
365366

366367
def create_celery_metrics(self, meter) -> None:
367368
self.metrics = {

instrumentation/opentelemetry-instrumentation-celery/tests/test_metrics.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,8 @@ def test_basic_metric(self):
4242
task_runtime_estimated = (default_timer() - start_time) * 1000
4343

4444
metrics = self.get_metrics()
45+
self.assertEqual(CeleryInstrumentor().task_id_to_start_time, {})
46+
4547
CeleryInstrumentor().uninstrument()
4648
self.assertEqual(len(metrics), 1)
4749

0 commit comments

Comments
 (0)