Skip to content

Commit abbff1a

Browse files
committed
Align tests with the same assertion
1 parent e8d3cc0 commit abbff1a

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

instrumentation/opentelemetry-instrumentation-flask/tests/test_programmatic.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -740,7 +740,7 @@ def test_flask_metrics_excluded_urls(self):
740740
start = default_timer()
741741
self.client.get("/env_excluded_arg/123")
742742
self.client.get("/env_excluded_noarg")
743-
self.client.get("/hello/756")
743+
self.client.get("/env_excluded_arg/789")
744744
duration = max(round((default_timer() - start) * 1000), 0)
745745
metrics_list = self.memory_metrics_reader.get_metrics_data()
746746
number_data_point_seen = False
@@ -756,7 +756,7 @@ def test_flask_metrics_excluded_urls(self):
756756
self.assertEqual(len(data_points), 1)
757757
for point in data_points:
758758
if isinstance(point, HistogramDataPoint):
759-
self.assertEqual(point.count, 1)
759+
self.assertEqual(point.count, 0)
760760
self.assertAlmostEqual(
761761
duration, point.sum, delta=10
762762
)
@@ -768,7 +768,8 @@ def test_flask_metrics_excluded_urls(self):
768768
attr,
769769
_recommended_metrics_attrs_old[metric.name],
770770
)
771-
self.assertTrue(number_data_point_seen and histogram_data_point_seen)
771+
self.assertTrue(number_data_point_seen)
772+
self.assertFalse(histogram_data_point_seen)
772773

773774
def test_flask_metrics_excluded_urls_new_semconv(self):
774775
start = default_timer()

0 commit comments

Comments
 (0)