making pymysql follow semantic conventions

Author: Joice-crypto

instrumentation/opentelemetry-instrumentation-pymysql/src/opentelemetry/instrumentation/pymysql/__init__.py

@@ -50,10 +50,10 @@
 from opentelemetry.instrumentation.pymysql.version import __version__
 
 _CONNECTION_ATTRIBUTES = {
-    "database": "db",
-    "port": "port",
-    "host": "host",
-    "user": "user",
+    "db.namespace": "db",
+    "server.port": "port",
+    "server.address": "host",
+    "db.user": "user",
 }
 _DATABASE_SYSTEM = "mysql"
 

tests/opentelemetry-docker-tests/tests/redis/test_redis_functional.py

@@ -17,15 +17,11 @@
 
 import redis
 import redis.asyncio
-
-from redis.exceptions import ResponseError
-from redis.commands.search.indexDefinition import IndexDefinition, IndexType
 from redis.commands.search.aggregation import AggregateRequest
+from redis.commands.search.field import TextField, VectorField
+from redis.commands.search.indexDefinition import IndexDefinition, IndexType
 from redis.commands.search.query import Query
-from redis.commands.search.field import (
-    TextField,
-    VectorField,
-)
+from redis.exceptions import ResponseError
 
 from opentelemetry import trace
 from opentelemetry.instrumentation.redis import RedisInstrumentor
@@ -644,34 +640,44 @@ def prepare_data(self):
             self.redis_client.ft("idx:test_vss").dropindex(True)
         except ResponseError:
             print("No such index")
-        item = {"name": "test",
-                "value": "test_value",
-                "embeddings": [0.1] * 256}
+        item = {
+            "name": "test",
+            "value": "test_value",
+            "embeddings": [0.1] * 256,
+        }
         pipeline = self.redis_client.pipeline()
         pipeline.json().set(f"test:001", "$", item)
         res = pipeline.execute()
         assert False not in res
 
     def create_index(self):
-        schema =  ( 
-                    TextField("$.name", no_stem=True, as_name="name"),
-                    TextField("$.value", no_stem=True, as_name="value"),
-                    VectorField("$.embeddings",
-                                "FLAT",
-                                {
-                                    "TYPE": "FLOAT32",
-                                    "DIM": self.embedding_dim,
-                                    "DISTANCE_METRIC": "COSINE",
-                                },
-                                as_name="vector",),
-                    )
-        definition = IndexDefinition(prefix=["test:"], index_type=IndexType.JSON)
-        res = self.redis_client.ft("idx:test_vss").create_index(fields=schema, definition=definition)
+        schema = (
+            TextField("$.name", no_stem=True, as_name="name"),
+            TextField("$.value", no_stem=True, as_name="value"),
+            VectorField(
+                "$.embeddings",
+                "FLAT",
+                {
+                    "TYPE": "FLOAT32",
+                    "DIM": self.embedding_dim,
+                    "DISTANCE_METRIC": "COSINE",
+                },
+                as_name="vector",
+            ),
+        )
+        definition = IndexDefinition(
+            prefix=["test:"], index_type=IndexType.JSON
+        )
+        res = self.redis_client.ft("idx:test_vss").create_index(
+            fields=schema, definition=definition
+        )
         assert "OK" in str(res)
 
     def test_redis_create_index(self):
         spans = self.memory_exporter.get_finished_spans()
-        span = next(span for span in spans if span.name == "redis.create_index")
+        span = next(
+            span for span in spans if span.name == "redis.create_index"
+        )
         assert "redis.create_index.fields" in span.attributes
 
     def test_redis_query(self):