Skip to content

Commit b1308a0

Browse files
committed
use get_sorted_metrics
Signed-off-by: emdneto <[email protected]>
1 parent 0a700b2 commit b1308a0

File tree

1 file changed

+7
-11
lines changed

1 file changed

+7
-11
lines changed

instrumentation/opentelemetry-instrumentation-requests/tests/test_requests_integration.py

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -852,18 +852,14 @@ def test_basic_metric_non_recording_span(self):
852852
mock_span.is_recording.return_value = False
853853
result = self.perform_request(self.URL)
854854
self.assertEqual(result.text, "Hello!")
855-
856855
self.assertFalse(mock_span.is_recording())
857856
self.assertTrue(mock_span.is_recording.called)
858857
self.assertFalse(mock_span.set_attribute.called)
859858
self.assertFalse(mock_span.set_status.called)
860-
metrics_list = self.memory_metrics_reader.get_metrics_data()
861-
# pylint: disable=too-many-nested-blocks
862-
for resource_metric in metrics_list.resource_metrics:
863-
for scope_metrics in resource_metric.scope_metrics:
864-
for metric in scope_metrics.metrics:
865-
for point in list(metric.data.data_points):
866-
self.assertDictEqual(
867-
expected_attributes, dict(point.attributes)
868-
)
869-
self.assertEqual(point.count, 1)
859+
metrics = self.get_sorted_metrics()
860+
self.assertEqual(len(metrics), 1)
861+
duration_data_point = metrics[0].data.data_points[0]
862+
self.assertDictEqual(
863+
expected_attributes, dict(duration_data_point.attributes)
864+
)
865+
self.assertEqual(duration_data_point.count, 1)

0 commit comments

Comments
 (0)