Skip to content

Commit b81343a

Browse files
committed
narrow down FastAPI exception tests to relevant spans
1 parent 2bc27d1 commit b81343a

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

instrumentation/opentelemetry-instrumentation-fastapi/tests/test_fastapi_instrumentation.py

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1889,7 +1889,9 @@ def setUp(self):
18891889

18901890
self.app = fastapi.FastAPI()
18911891

1892-
otel_fastapi.FastAPIInstrumentor().instrument_app(self.app)
1892+
otel_fastapi.FastAPIInstrumentor().instrument_app(
1893+
self.app, exclude_spans=["receive", "send"]
1894+
)
18931895
self.client = TestClient(self.app)
18941896
self.tracer = self.tracer_provider.get_tracer(__name__)
18951897
self.executed = 0
@@ -1932,8 +1934,8 @@ async def _():
19321934

19331935
spans = self.memory_exporter.get_finished_spans()
19341936

1935-
self.assertEqual(len(spans), 3)
1936-
span = spans[2]
1937+
self.assertEqual(len(spans), 1)
1938+
span = spans[0]
19371939
self.assertEqual(span.name, "GET /foobar")
19381940
self.assertEqual(span.attributes.get(HTTP_STATUS_CODE), status_code)
19391941
self.assertEqual(span.status.status_code, StatusCode.ERROR)
@@ -1982,8 +1984,8 @@ async def _():
19821984

19831985
spans = self.memory_exporter.get_finished_spans()
19841986

1985-
self.assertEqual(len(spans), 3)
1986-
span = spans[2]
1987+
self.assertEqual(len(spans), 1)
1988+
span = spans[0]
19871989
self.assertEqual(span.name, "GET /foobar")
19881990
self.assertEqual(span.attributes.get(HTTP_STATUS_CODE), 500)
19891991
self.assertEqual(span.status.status_code, StatusCode.ERROR)
@@ -2016,8 +2018,8 @@ async def _(*_):
20162018

20172019
spans = self.memory_exporter.get_finished_spans()
20182020

2019-
self.assertEqual(len(spans), 3)
2020-
span = spans[2]
2021+
self.assertEqual(len(spans), 1)
2022+
span = spans[0]
20212023
self.assertEqual(span.name, "GET /foobar")
20222024
self.assertEqual(span.attributes.get(HTTP_STATUS_CODE), 500)
20232025
self.assertEqual(span.status.status_code, StatusCode.ERROR)

0 commit comments

Comments
 (0)