refactor(flask): replace SpanAttributes with semconv attributes (fix ruff linting)

Author: artemziborev

instrumentation/opentelemetry-instrumentation-flask/src/opentelemetry/instrumentation/flask/__init__.py

@@ -273,14 +273,14 @@ def response_hook(span: Span, status: str, response_headers: List):
 )
 from opentelemetry.instrumentation.utils import _start_internal_or_server_span
 from opentelemetry.metrics import get_meter
+from opentelemetry.semconv._incubating.attributes.http_attributes import (
+    HTTP_ROUTE,
+    HTTP_TARGET,
+)
 from opentelemetry.semconv.metrics import MetricInstruments
 from opentelemetry.semconv.metrics.http_metrics import (
     HTTP_SERVER_REQUEST_DURATION,
 )
-from opentelemetry.semconv._incubating.attributes.http_attributes import (
-    HTTP_TARGET,
-    HTTP_ROUTE
-)
 from opentelemetry.util._importlib_metadata import version
 from opentelemetry.util.http import (
     get_excluded_urls,
@@ -406,9 +406,7 @@ def _start_response(status, response_headers, *args, **kwargs):
 
             if request_route:
                 # http.target to be included in old semantic conventions
-                duration_attrs_old[HTTP_TARGET] = str(
-                    request_route
-                )
+                duration_attrs_old[HTTP_TARGET] = str(request_route)
 
             duration_histogram_old.record(
                 max(round(duration_s * 1000), 0), duration_attrs_old

instrumentation/opentelemetry-instrumentation-flask/tests/test_programmatic.py

@@ -40,37 +40,34 @@
     NumberDataPoint,
 )
 from opentelemetry.sdk.resources import Resource
-from opentelemetry.semconv.attributes.error_attributes import ERROR_TYPE
 from opentelemetry.semconv._incubating.attributes.http_attributes import (
-    HTTP_METHOD,
-    HTTP_SERVER_NAME,
-    HTTP_SCHEME,
-    HTTP_HOST,
-    HTTP_TARGET,
     HTTP_FLAVOR,
-    HTTP_STATUS_CODE,
+    HTTP_HOST,
+    HTTP_METHOD,
     HTTP_REQUEST_METHOD,
     HTTP_RESPONSE_STATUS_CODE,
     HTTP_ROUTE,
-
-
+    HTTP_SCHEME,
+    HTTP_SERVER_NAME,
+    HTTP_STATUS_CODE,
+    HTTP_TARGET,
 )
 from opentelemetry.semconv._incubating.attributes.net_attributes import (
-    NET_HOST_PORT,
     NET_HOST_NAME,
-
+    NET_HOST_PORT,
+)
+from opentelemetry.semconv._incubating.attributes.network_attributes import (
+    NETWORK_PROTOCOL_VERSION,
 )
 from opentelemetry.semconv._incubating.attributes.server_attributes import (
-    SERVER_PORT,
     SERVER_ADDRESS,
+    SERVER_PORT,
 )
 from opentelemetry.semconv._incubating.attributes.url_attributes import (
     URL_PATH,
     URL_SCHEME,
 )
-from opentelemetry.semconv._incubating.attributes.network_attributes import (
-    NETWORK_PROTOCOL_VERSION
-)
+from opentelemetry.semconv.attributes.error_attributes import ERROR_TYPE
 from opentelemetry.test.wsgitestutil import WsgiTestBase
 from opentelemetry.util.http import (
     OTEL_INSTRUMENTATION_HTTP_CAPTURE_HEADERS_SANITIZE_FIELDS,