address comments

Author: jj22ee

sdk-extension/opentelemetry-sdk-extension-aws/README.rst

@@ -76,7 +76,7 @@ detector.
 
 
 Usage (AWS X-Ray Remote Sampler)
-----------------------------
+--------------------------------
 
 
 Use the provided AWS X-Ray Remote Sampler by setting this sampler in your instrumented application:

sdk-extension/opentelemetry-sdk-extension-aws/pyproject.toml

@@ -30,6 +30,7 @@ dependencies = [
   "opentelemetry-sdk ~= 1.23",
   "opentelemetry-instrumentation ~= 0.44b0",
   "opentelemetry-semantic-conventions ~= 0.44b0",
+  "requests ~= 2.28",
 ]
 
 [project.entry-points.opentelemetry_id_generator]

sdk-extension/opentelemetry-sdk-extension-aws/src/opentelemetry/sdk/extension/aws/trace/sampler/aws_xray_remote_sampler.py

@@ -46,6 +46,8 @@
 DEFAULT_RULES_POLLING_INTERVAL_SECONDS = 300
 
 
+# WORK IN PROGRESS
+#
 # Wrapper class to ensure that all XRay Sampler Functionality in _AwsXRayRemoteSampler
 # uses ParentBased logic to respect the parent span's sampling decision
 class AwsXRayRemoteSampler(Sampler):
@@ -65,7 +67,6 @@ def __init__(
             )
         )
 
-    # pylint: disable=no-self-use
     @override
     def should_sample(
         self,
@@ -93,6 +94,8 @@ def get_description(self) -> str:
         return f"AwsXRayRemoteSampler{{root:{self._root.get_description()}}}"
 
 
+# WORK IN PROGRESS
+#
 # _AwsXRayRemoteSampler contains all core XRay Sampler Functionality,
 # however it is NOT Parent-based (e.g. Sample logic runs for each span)
 # Not intended for external use, use Parent-based `AwsXRayRemoteSampler` instead.
@@ -195,24 +198,7 @@ def __start_sampling_rule_poller(self) -> None:
         self._rules_timer.start()
 
     def __generate_client_id(self) -> str:
-        hex_chars = [
-            "0",
-            "1",
-            "2",
-            "3",
-            "4",
-            "5",
-            "6",
-            "7",
-            "8",
-            "9",
-            "a",
-            "b",
-            "c",
-            "d",
-            "e",
-            "f",
-        ]
+        hex_chars = "0123456789abcdef"
         client_id_array: list[str] = []
         for _ in range(0, 24):
             client_id_array.append(random.choice(hex_chars))