Skip to content

Commit c0132c6

Browse files
xrmxshalevr
andauthored
urllib: don't assume we control the bucket metrics data point get in (#3341)
Instead of expecting an entry in a specific bucket, just sum all of them and assert we have the correct number of entries. Co-authored-by: Shalev Roda <[email protected]>
1 parent 6572081 commit c0132c6

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

instrumentation/opentelemetry-instrumentation-urllib/tests/test_metrics_instrumentation.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -414,16 +414,16 @@ def test_metric_uninstrument(self):
414414
) = metrics[:3]
415415

416416
self.assertEqual(
417-
client_duration.data.data_points[0].bucket_counts[1],
417+
sum(client_duration.data.data_points[0].bucket_counts),
418418
1,
419419
)
420420

421421
self.assertEqual(
422-
client_request_size.data.data_points[0].bucket_counts[0],
422+
sum(client_request_size.data.data_points[0].bucket_counts),
423423
1,
424424
)
425425
self.assertEqual(
426-
client_response_size.data.data_points[0].bucket_counts[2],
426+
sum(client_response_size.data.data_points[0].bucket_counts),
427427
1,
428428
)
429429

@@ -439,15 +439,15 @@ def test_metric_uninstrument(self):
439439
) = metrics[:3]
440440

441441
self.assertEqual(
442-
client_duration.data.data_points[0].bucket_counts[1],
442+
sum(client_duration.data.data_points[0].bucket_counts),
443443
2,
444444
)
445445
self.assertEqual(
446-
client_request_size.data.data_points[0].bucket_counts[0],
446+
sum(client_request_size.data.data_points[0].bucket_counts),
447447
2,
448448
)
449449
self.assertEqual(
450-
client_response_size.data.data_points[0].bucket_counts[2],
450+
sum(client_response_size.data.data_points[0].bucket_counts),
451451
2,
452452
)
453453

@@ -467,15 +467,15 @@ def test_metric_uninstrument(self):
467467
self.assertEqual(len(metrics), 3)
468468

469469
self.assertEqual(
470-
client_duration.data.data_points[0].bucket_counts[1],
470+
sum(client_duration.data.data_points[0].bucket_counts),
471471
2,
472472
)
473473
self.assertEqual(
474-
client_request_size.data.data_points[0].bucket_counts[0],
474+
sum(client_request_size.data.data_points[0].bucket_counts),
475475
2,
476476
)
477477

478478
self.assertEqual(
479-
client_response_size.data.data_points[0].bucket_counts[2],
479+
sum(client_response_size.data.data_points[0].bucket_counts),
480480
2,
481481
)

0 commit comments

Comments
 (0)