Skip to content

Commit ca079cb

Browse files
authored
feat: change semcov util/opentelemetry-util-http (#3592)
1 parent 40d8942 commit ca079cb

File tree

2 files changed

+29
-16
lines changed

2 files changed

+29
-16
lines changed

util/opentelemetry-util-http/src/opentelemetry/util/http/__init__.py

Lines changed: 25 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,18 @@
2222
from typing import Callable, Iterable, overload
2323
from urllib.parse import urlparse, urlunparse
2424

25-
from opentelemetry.semconv.trace import SpanAttributes
25+
from opentelemetry.semconv._incubating.attributes.http_attributes import (
26+
HTTP_FLAVOR,
27+
HTTP_HOST,
28+
HTTP_METHOD,
29+
HTTP_SCHEME,
30+
HTTP_SERVER_NAME,
31+
HTTP_STATUS_CODE,
32+
)
33+
from opentelemetry.semconv._incubating.attributes.net_attributes import (
34+
NET_HOST_NAME,
35+
NET_HOST_PORT,
36+
)
2637

2738
OTEL_INSTRUMENTATION_HTTP_CAPTURE_HEADERS_SANITIZE_FIELDS = (
2839
"OTEL_INSTRUMENTATION_HTTP_CAPTURE_HEADERS_SANITIZE_FIELDS"
@@ -40,22 +51,22 @@
4051

4152
# List of recommended metrics attributes
4253
_duration_attrs = {
43-
SpanAttributes.HTTP_METHOD,
44-
SpanAttributes.HTTP_HOST,
45-
SpanAttributes.HTTP_SCHEME,
46-
SpanAttributes.HTTP_STATUS_CODE,
47-
SpanAttributes.HTTP_FLAVOR,
48-
SpanAttributes.HTTP_SERVER_NAME,
49-
SpanAttributes.NET_HOST_NAME,
50-
SpanAttributes.NET_HOST_PORT,
54+
HTTP_METHOD,
55+
HTTP_HOST,
56+
HTTP_SCHEME,
57+
HTTP_STATUS_CODE,
58+
HTTP_FLAVOR,
59+
HTTP_SERVER_NAME,
60+
NET_HOST_NAME,
61+
NET_HOST_PORT,
5162
}
5263

5364
_active_requests_count_attrs = {
54-
SpanAttributes.HTTP_METHOD,
55-
SpanAttributes.HTTP_HOST,
56-
SpanAttributes.HTTP_SCHEME,
57-
SpanAttributes.HTTP_FLAVOR,
58-
SpanAttributes.HTTP_SERVER_NAME,
65+
HTTP_METHOD,
66+
HTTP_HOST,
67+
HTTP_SCHEME,
68+
HTTP_FLAVOR,
69+
HTTP_SERVER_NAME,
5970
}
6071

6172

util/opentelemetry-util-http/src/opentelemetry/util/http/httplib.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,9 @@
3131
from opentelemetry import context
3232
from opentelemetry.instrumentation.instrumentor import BaseInstrumentor
3333
from opentelemetry.instrumentation.utils import unwrap
34-
from opentelemetry.semconv.trace import SpanAttributes
34+
from opentelemetry.semconv._incubating.attributes.net_attributes import (
35+
NET_PEER_IP,
36+
)
3537
from opentelemetry.trace.span import Span
3638

3739
_STATE_KEY = "httpbase_instrumentation_state"
@@ -111,7 +113,7 @@ def trysetip(
111113
)
112114
else:
113115
for span in spanlist:
114-
span.set_attribute(SpanAttributes.NET_PEER_IP, ip)
116+
span.set_attribute(NET_PEER_IP, ip)
115117
return True
116118

117119

0 commit comments

Comments
 (0)