Skip to content

Commit caf8b58

Browse files
authored
openai-v2: use generic request seed instead of openai specific one (#4036)
* openai-v2: use generic request seed instead of openai specific one * Add changelog * Bump schema url to 1.30.0 embeddings semconv has been added to 1.30.0 semconv as well.
1 parent fd79ae9 commit caf8b58

File tree

5 files changed

+8
-10
lines changed

5 files changed

+8
-10
lines changed

instrumentation-genai/opentelemetry-instrumentation-openai-v2/CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1313
([#4028](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/4028))
1414
- Fix crash with streaming `with_raw_response`
1515
([#4033](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/4033))
16+
- Bump to 1.30.0 semconv schema: `gen_ai.request.seed` instead of `gen_ai.openai.request.seed`
17+
([#4036](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/4036))
1618

1719
## Version 2.2b0 (2025-11-25)
1820

instrumentation-genai/opentelemetry-instrumentation-openai-v2/src/opentelemetry/instrumentation/openai_v2/__init__.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -76,21 +76,21 @@ def _instrument(self, **kwargs):
7676
__name__,
7777
"",
7878
tracer_provider,
79-
schema_url=Schemas.V1_28_0.value,
79+
schema_url=Schemas.V1_30_0.value,
8080
)
8181
logger_provider = kwargs.get("logger_provider")
8282
logger = get_logger(
8383
__name__,
8484
"",
85-
schema_url=Schemas.V1_28_0.value,
85+
schema_url=Schemas.V1_30_0.value,
8686
logger_provider=logger_provider,
8787
)
8888
meter_provider = kwargs.get("meter_provider")
8989
self._meter = get_meter(
9090
__name__,
9191
"",
9292
meter_provider,
93-
schema_url=Schemas.V1_28_0.value,
93+
schema_url=Schemas.V1_30_0.value,
9494
)
9595

9696
instruments = Instruments(self._meter)

instrumentation-genai/opentelemetry-instrumentation-openai-v2/src/opentelemetry/instrumentation/openai_v2/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@ def get_llm_request_attributes(
220220
GenAIAttributes.GEN_AI_REQUEST_FREQUENCY_PENALTY: kwargs.get(
221221
"frequency_penalty"
222222
),
223-
GenAIAttributes.GEN_AI_OPENAI_REQUEST_SEED: kwargs.get("seed"),
223+
GenAIAttributes.GEN_AI_REQUEST_SEED: kwargs.get("seed"),
224224
}
225225
)
226226

instrumentation-genai/opentelemetry-instrumentation-openai-v2/tests/test_async_chat_completions.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -186,9 +186,7 @@ async def test_async_chat_completion_extra_params(
186186
request_service_tier="default",
187187
response_service_tier=getattr(response, "service_tier", None),
188188
)
189-
assert (
190-
spans[0].attributes[GenAIAttributes.GEN_AI_OPENAI_REQUEST_SEED] == 42
191-
)
189+
assert spans[0].attributes[GenAIAttributes.GEN_AI_REQUEST_SEED] == 42
192190
assert (
193191
spans[0].attributes[GenAIAttributes.GEN_AI_REQUEST_TEMPERATURE] == 0.5
194192
)

instrumentation-genai/opentelemetry-instrumentation-openai-v2/tests/test_chat_completions.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -276,9 +276,7 @@ def test_chat_completion_extra_params(
276276
request_service_tier="default",
277277
response_service_tier=getattr(response, "service_tier", None),
278278
)
279-
assert (
280-
spans[0].attributes[GenAIAttributes.GEN_AI_OPENAI_REQUEST_SEED] == 42
281-
)
279+
assert spans[0].attributes[GenAIAttributes.GEN_AI_REQUEST_SEED] == 42
282280
assert (
283281
spans[0].attributes[GenAIAttributes.GEN_AI_REQUEST_TEMPERATURE] == 0.5
284282
)

0 commit comments

Comments
 (0)