Skip to content

Commit cb4ca3b

Browse files
committed
Update to specify attributes from SemConv constants per PR feedback.
1 parent 3107e56 commit cb4ca3b

File tree

3 files changed

+16
-16
lines changed

3 files changed

+16
-16
lines changed

instrumentation-genai/opentelemetry-instrumentation-google-genai/pyproject.toml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,9 @@ classifiers = [
3737
"Programming Language :: Python :: 3.12"
3838
]
3939
dependencies = [
40-
"opentelemetry-api >=1.30.0, <2",
41-
"opentelemetry-instrumentation >=0.51b0, <2",
42-
"opentelemetry-semantic-conventions >=0.51b0, <2"
40+
"opentelemetry-api >=1.31.1, <2",
41+
"opentelemetry-instrumentation >=0.52b1, <2",
42+
"opentelemetry-semantic-conventions >=0.52b1, <2"
4343
]
4444

4545
[project.optional-dependencies]

instrumentation-genai/opentelemetry-instrumentation-google-genai/src/opentelemetry/instrumentation/google_genai/generate_content.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -173,15 +173,15 @@ def _add_request_options_to_span(
173173
rename_keys={
174174
# TODO: add more entries here as more semantic conventions are
175175
# generalized to cover more of the available config options.
176-
"gcp.gen_ai.request.temperature": "gen_ai.request.temperature",
177-
"gcp.gen_ai.request.top_k": "gen_ai.request.top_k",
178-
"gcp.gen_ai.request.top_p": "gen_ai.request.top_p",
179-
"gcp.gen_ai.request.candidate_count": "gen_ai.request.choice.count",
180-
"gcp.gen_ai.request.max_output_tokens": "gen_ai.request.max_tokens",
181-
"gcp.gen_ai.request.stop_sequences": "gen_ai.request.stop_sequences",
182-
"gcp.gen_ai.request.frequency_penalty": "gen_ai.request.frequency_penalty",
183-
"gcp.gen_ai.request.presence_penalty": "gen_ai.request.presence_penalty",
184-
"gcp.gen_ai.request.seed": "gen_ai.request.seed",
176+
"gcp.gen_ai.request.temperature": gen_ai_attributes.GEN_AI_REQUEST_TEMPERATURE,
177+
"gcp.gen_ai.request.top_k": gen_ai_attributes.GEN_AI_REQUEST_TOP_K,
178+
"gcp.gen_ai.request.top_p": gen_ai_attributes.GEN_AI_REQUEST_TOP_P,
179+
"gcp.gen_ai.request.candidate_count": gen_ai_attributes.GEN_AI_REQUEST_CHOICE_COUNT,
180+
"gcp.gen_ai.request.max_output_tokens": gen_ai_attributes.GEN_AI_REQUEST_MAX_TOKENS,
181+
"gcp.gen_ai.request.stop_sequences": gen_ai_attributes.GEN_AI_REQUEST_STOP_SEQUENCES,
182+
"gcp.gen_ai.request.frequency_penalty": gen_ai_attributes.GEN_AI_REQUEST_FREQUENCY_PENALTY,
183+
"gcp.gen_ai.request.presence_penalty": gen_ai_attributes.GEN_AI_REQUEST_PRESENCE_PENALTY,
184+
"gcp.gen_ai.request.seed": gen_ai_attributes.GEN_AI_REQUEST_SEED,
185185
},
186186
)
187187
span.set_attributes(attributes)

instrumentation-genai/opentelemetry-instrumentation-google-genai/tests/requirements.oldest.txt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@ pytest-vcr==1.0.2
2121

2222
google-auth==2.15.0
2323
google-genai==1.0.0
24-
opentelemetry-api==1.30.0
25-
opentelemetry-sdk==1.30.0
26-
opentelemetry-semantic-conventions==0.51b0
27-
opentelemetry-instrumentation==0.51b0
24+
opentelemetry-api==1.31.1
25+
opentelemetry-sdk==1.31.1
26+
opentelemetry-semantic-conventions==0.52b1
27+
opentelemetry-instrumentation==0.52b1
2828

2929
# Install locally from the folder. This path is relative to the
3030
# root directory, given invocation from "tox" at root level.

0 commit comments

Comments
 (0)