Skip to content

Commit dd68241

Browse files
emdnetoxrmx
andauthored
fix pymssql entry_point for auto-instrumentation (#3214)
Signed-off-by: emdneto <[email protected]> Co-authored-by: Riccardo Magliocchetti <[email protected]>
1 parent eabab7d commit dd68241

File tree

2 files changed

+14
-1
lines changed

2 files changed

+14
-1
lines changed

instrumentation/opentelemetry-instrumentation-pymssql/pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ instruments = [
3737
]
3838

3939
[project.entry-points.opentelemetry_instrumentor]
40-
pymssql = "opentelemetry.instrumentation.pymssql:pymssqlInstrumentor"
40+
pymssql = "opentelemetry.instrumentation.pymssql:PyMSSQLInstrumentor"
4141

4242
[project.urls]
4343
Homepage = "https://github.com/open-telemetry/opentelemetry-python-contrib/tree/main/instrumentation/opentelemetry-instrumentation-pymssql"

instrumentation/opentelemetry-instrumentation-pymssql/tests/test_pymssql_integration.py

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
from opentelemetry.instrumentation.pymssql import PyMSSQLInstrumentor
2121
from opentelemetry.sdk import resources
2222
from opentelemetry.test.test_base import TestBase
23+
from opentelemetry.util._importlib_metadata import entry_points
2324

2425

2526
def mock_connect(*args, **kwargs):
@@ -182,3 +183,15 @@ def test_uninstrument_connection(self):
182183

183184
spans_list = self.memory_exporter.get_finished_spans()
184185
self.assertEqual(len(spans_list), 1)
186+
187+
def test_load_entry_point(self):
188+
self.assertIs(
189+
next(
190+
iter(
191+
entry_points(
192+
group="opentelemetry_instrumentor", name="pymssql"
193+
)
194+
)
195+
).load(),
196+
PyMSSQLInstrumentor,
197+
)

0 commit comments

Comments
 (0)