Skip to content

Commit e3277c4

Browse files
committed
Fix last typecheck issues..
1 parent 3eb7ab0 commit e3277c4

File tree

2 files changed

+3
-4
lines changed
  • instrumentation-genai/opentelemetry-instrumentation-vertexai/src/opentelemetry/instrumentation/vertexai

2 files changed

+3
-4
lines changed

instrumentation-genai/opentelemetry-instrumentation-vertexai/src/opentelemetry/instrumentation/vertexai/__init__.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@
4343

4444
from typing import Any, Collection
4545

46-
from typing_extensions import assert_never
4746
from wrapt import (
4847
wrap_function_wrapper, # type: ignore[reportUnknownVariableType]
4948
)
@@ -152,7 +151,7 @@ def _instrument(self, **kwargs: Any):
152151
sem_conv_opt_in_mode,
153152
)
154153
else:
155-
assert_never(sem_conv_opt_in_mode)
154+
raise RuntimeError(f"{sem_conv_opt_in_mode} mode not supported")
156155
for client_class, method_name, wrapper in _methods_to_wrap(
157156
method_wrappers
158157
):

instrumentation-genai/opentelemetry-instrumentation-vertexai/src/opentelemetry/instrumentation/vertexai/patch.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -266,9 +266,9 @@ def generate_content(
266266
response = None
267267
try:
268268
response = wrapped(*args, **kwargs)
269+
return response
269270
finally:
270271
handle_response(response)
271-
return response
272272

273273
async def agenerate_content(
274274
self,
@@ -303,6 +303,6 @@ async def agenerate_content(
303303
response = None
304304
try:
305305
response = await wrapped(*args, **kwargs)
306+
return response
306307
finally:
307308
handle_response(response)
308-
return response

0 commit comments

Comments
 (0)