Add timeout for waiting functions

Author: rbagd

instrumentation/opentelemetry-instrumentation-celery/tests/test_metrics.py

@@ -56,10 +56,11 @@ def tearDown(self):
         self._worker.stop()
         self._thread.join()
 
-    def wait_for_tasks_to_finish(self):
+    def wait_for_tasks_to_finish(self, timeout=30):
         """Blocks until all tasks in Celery worker are finished"""
 
         inspect = app.control.inspect()
+        start_time = time.time()
         while True:
             counter = 0
             for state in (
@@ -74,6 +75,9 @@ def wait_for_tasks_to_finish(self):
                 break
 
             time.sleep(0.5)
+            if time.time() - start_time > timeout:
+                raise TimeoutError("Timeout while waiting for tasks to finish.")
+
 
     def wait_for_metrics_until_finished(self, task_fn, *args):
         """
@@ -83,11 +87,11 @@ def wait_for_metrics_until_finished(self, task_fn, *args):
         """
 
         result = task_fn.delay(*args)
-
-        timeout = time.time() + 60 * 1
+        give_up_time = time.time() + 30
         while not result.ready():
-            if time.time() > timeout:
-                break
+            if time.time() > give_up_time:
+                raise TimeoutError("Timeout while waiting for task to finish.")
+
             time.sleep(0.05)
         return self.get_sorted_metrics()