Skip to content

Commit e469f8f

Browse files
committed
update CHANGELOG.md
1 parent 25dd2a9 commit e469f8f

File tree

3 files changed

+11
-2
lines changed

3 files changed

+11
-2
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1111
1212
## Unreleased
1313

14+
- `opentelemetry-sdk-extension-aws`: Update xray trace id generator for 'random-trace-id' flags compatibility
15+
([#4030](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/4030))
16+
1417
### Fixed
1518

1619
- `opentelemetry-util-http`, `opentelemetry-instrumentation-requests`, `opentelemetry-instrumentation-wsgi`, `opentelemetry-instrumentation-asgi`: normalize byte-valued user-agent headers before detecting synthetic sources so attributes are recorded reliably.

instrumentation/opentelemetry-instrumentation-boto3sqs/tests/test_boto3sqs_instrumentation.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,9 @@ def _default_span_attrs(self):
230230
}
231231

232232
@staticmethod
233-
def _to_trace_parent(trace_id: int, span_id: int, trace_flags: TraceFlags) -> str:
233+
def _to_trace_parent(
234+
trace_id: int, span_id: int, trace_flags: TraceFlags
235+
) -> str:
234236
return f"00-{format_trace_id(trace_id)}-{format_span_id(span_id)}-{trace_flags:02x}".lower()
235237

236238
def _get_only_span(self):
@@ -254,7 +256,9 @@ def _add_trace_parent(
254256
self, message: Dict[str, Any], trace_id: int, span_id: int
255257
):
256258
message["MessageAttributes"]["traceparent"] = {
257-
"StringValue": self._to_trace_parent(trace_id, span_id, TraceFlags.get_default()),
259+
"StringValue": self._to_trace_parent(
260+
trace_id, span_id, TraceFlags.get_default()
261+
),
258262
"DataType": "String",
259263
}
260264

sdk-extension/opentelemetry-sdk-extension-aws/src/opentelemetry/sdk/extension/aws/trace/aws_xray_id_generator.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,10 +77,12 @@ class AwsXRayIdGenerator(IdGenerator):
7777
def generate_span_id(self) -> int:
7878
return self.random_id_generator.generate_span_id()
7979

80+
# pylint: disable=no-self-use
8081
def generate_trace_id(self) -> int:
8182
trace_time = int(time.time())
8283
trace_identifier = random.getrandbits(96)
8384
return (trace_time << 96) + trace_identifier
8485

86+
# pylint: disable=no-self-use
8587
def is_trace_id_random(self) -> bool:
8688
return True

0 commit comments

Comments
 (0)