Skip to content

Commit e4cc7fa

Browse files
committed
Update
1 parent a36a773 commit e4cc7fa

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

instrumentation/opentelemetry-instrumentation-httpx/tests/test_httpx_integration.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -436,7 +436,7 @@ def test_basic_both_semconv(self):
436436
# Validate metrics
437437
metrics = self.get_sorted_metrics()
438438
self.assertEqual(len(metrics), 2)
439-
# New convention
439+
# Old convention
440440
self.assertEqual(
441441
dict(metrics[0].data.data_points[0].attributes),
442442
{
@@ -449,7 +449,8 @@ def test_basic_both_semconv(self):
449449
SpanAttributes.HTTP_STATUS_CODE: 200,
450450
},
451451
)
452-
# Old convention
452+
self.assertEqual(metrics[0].name, "http.client.duration")
453+
# New convention
453454
self.assertEqual(
454455
dict(metrics[1].data.data_points[0].attributes),
455456
{
@@ -460,6 +461,7 @@ def test_basic_both_semconv(self):
460461
SERVER_PORT: 8080,
461462
},
462463
)
464+
self.assertEqual(metrics[1].name, "http.client.request.duration")
463465

464466
def test_basic_multiple(self):
465467
self.perform_request(self.URL)

0 commit comments

Comments
 (0)